Skip to content

Commit 72e0791

Browse files
committed
Replaced individual file warnings in 'rsync' with a summary of the batch
1 parent 0fa51e3 commit 72e0791

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

src/murfey/client/rsync.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,9 +461,20 @@ def parse_stderr(line: str):
461461

462462
self.notify(successful_updates, secondary=True)
463463

464+
# Print out a summary message for each file transfer batch instead of individual messages
465+
# List out file paths as stored in memory to see if issue is due to file path mismatch
466+
if len(set(relative_filenames) - transfer_success) != 0:
467+
logger.debug(
468+
f"{len(set(relative_filenames) - transfer_success)} files were not transferred | "
469+
f"Files identified for transfer ({len(relative_filenames)}): {relative_filenames!r} | "
470+
f"Files successfully transferred ({len(transfer_success)}): {list(transfer_success)!r} | "
471+
f"Missing files: {list(set(relative_filenames) - transfer_success)!r}"
472+
)
473+
464474
# Compare files from rsync stdout to original list to verify transfer
465475
for f in set(relative_filenames) - transfer_success:
466-
logger.warning(f"Transfer of file {f.name!r} considered a failure")
476+
# Mute individual file warnings; replace with summarised one above
477+
# logger.warning(f"Transfer of file {f.name!r} considered a failure")
467478
self._files_transferred += 1
468479
current_outstanding = self.queue.unfinished_tasks - (
469480
self._files_transferred - previously_transferred

0 commit comments

Comments
 (0)