Catch case where no rsync was attempted so no return code exists for the subprocess

Author: d-j-hatton

src/murfey/client/rsync.py

@@ -3,6 +3,7 @@
 import logging
 import os
 import queue
+import subprocess
 import threading
 import time
 from enum import Enum
@@ -383,6 +384,7 @@ def parse_stderr(line: str):
 
         rsync_cmd.extend([".", self._remote])
 
+        result: subprocess.CompletedProcess | None = None
         success = True
         if rsync_stdin:
             result = procrunner.run(
@@ -394,7 +396,7 @@ def parse_stderr(line: str):
                 print_stdout=False,
                 print_stderr=False,
             )
-            success = result.returncode == 0
+            success = result.returncode == 0 if result else False
 
         if rsync_stdin_remove:
             rsync_cmd.insert(-2, "--remove-source-files")
@@ -409,7 +411,7 @@ def parse_stderr(line: str):
             )
 
             if success:
-                success = result.returncode == 0
+                success = result.returncode == 0 if result else False
 
         self.notify(successful_updates, secondary=True)
 
@@ -429,8 +431,11 @@ def parse_stderr(line: str):
             self.notify(update)
             success = False
 
-        logger.log(
-            logging.WARNING if result.returncode else logging.DEBUG,
-            f"rsync process finished with return code {result.returncode}",
-        )
+        if result is None:
+            logger.error(f"No rsync process ran for files: {files}")
+        else:
+            logger.log(
+                logging.WARNING if result.returncode else logging.DEBUG,
+                f"rsync process finished with return code {result.returncode}",
+            )
         return success