Skip to content

Commit 8472e36

Browse files
committed
Need to convert non-str values to str before applying sanitisation
1 parent 8567d8d commit 8472e36

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/murfey/server/__init__.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,9 @@
4444
from workflows.transport.pika_transport import PikaTransport
4545

4646
import murfey
47-
import murfey.server.ispyb
4847
import murfey.server.prometheus as prom
49-
import murfey.server.websocket
5048
import murfey.util.db as db
49+
from murfey.server.ispyb import get_session_id
5150
from murfey.server.murfey_db import url # murfey_db
5251
from murfey.util import LogFilter
5352
from murfey.util.config import (
@@ -2207,7 +2206,7 @@ def feedback_callback(header: dict, message: dict) -> None:
22072206
_transport_object.transport.ack(header)
22082207
return None
22092208
elif message["register"] == "data_collection_group":
2210-
ispyb_session_id = murfey.server.ispyb.get_session_id(
2209+
ispyb_session_id = get_session_id(
22112210
microscope=message["microscope"],
22122211
proposal_code=message["proposal_code"],
22132212
proposal_number=message["proposal_number"],
@@ -2292,11 +2291,11 @@ def feedback_callback(header: dict, message: dict) -> None:
22922291
return None
22932292
elif message["register"] == "data_collection":
22942293
logger.debug(
2295-
f"Received message named 'data_collection' containing the following items:\n"
2296-
f"{', '.join([f'{sanitise(key)}: {sanitise(value)}' for key, value in message.items()])}"
2294+
"Received message named 'data_collection' containing the following items:\n"
2295+
f"{', '.join([f'{key}: {sanitise(str(value))}' for key, value in message.items()])}"
22972296
)
22982297
murfey_session_id = message["session_id"]
2299-
ispyb_session_id = murfey.server.ispyb.get_session_id(
2298+
ispyb_session_id = get_session_id(
23002299
microscope=message["microscope"],
23012300
proposal_code=message["proposal_code"],
23022301
proposal_number=message["proposal_number"],

src/murfey/server/ispyb.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -564,8 +564,8 @@ def get_session_id(
564564
"Looking up ISPyB BLSession ID using the following values:\n"
565565
f"microscope: {sanitise(microscope)}\n"
566566
f"proposal_code: {sanitise(proposal_code)}\n"
567-
f"proposal_number: {sanitise(proposal_number)}\n"
568-
f"visit_number: {sanitise(visit_number)}\n"
567+
f"proposal_number: {sanitise(str(proposal_number))}\n"
568+
f"visit_number: {sanitise(str(visit_number))}\n"
569569
)
570570

571571
# Lookup BLSession ID

0 commit comments

Comments
 (0)