Guard against log injection

d-j-hatton · d-j-hatton · commit 876da039345f · 2025-01-13T13:35:28.000Z
diff --git a/src/murfey/server/api/__init__.py b/src/murfey/server/api/__init__.py
@@ -1137,7 +1137,7 @@ async def request_spa_preprocessing(
         )
     except Exception as e:
         log.warning(
-            f"Foil hole ID not found for foil hole {proc_file.foil_hole_id}: {e}",
+            f"Foil hole ID not found for foil hole {sanitise(str(proc_file.foil_hole_id))}: {e}",
             exc_info=True,
         )
         foil_hole_id = None

Original file line number	Diff line number	Diff line change
`@@ -1137,7 +1137,7 @@ async def request_spa_preprocessing(`
`1137`	`1137`	`)`
`1138`	`1138`	`except Exception as e:`
`1139`	`1139`	`log.warning(`
`1140`		`- f"Foil hole ID not found for foil hole {proc_file.foil_hole_id}: {e}",`
	`1140`	`+ f"Foil hole ID not found for foil hole {sanitise(str(proc_file.foil_hole_id))}: {e}",`
`1141`	`1141`	`exc_info=True,`
`1142`	`1142`	`)`
`1143`	`1143`	`foil_hole_id = None`