Skip to content

Commit 8e3bd26

Browse files
committed
Fixed broken imports due to 'murfey.server' refactor; moved FastAPI templates to 'murfey.server.api' instead.
1 parent 807c8cf commit 8e3bd26

File tree

7 files changed

+22
-21
lines changed

7 files changed

+22
-21
lines changed

src/murfey/server/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from __future__ import annotations
22

3+
from importlib.resources import files
34
from typing import TYPE_CHECKING
45

56
# Classes are only imported for type checking purposes
@@ -10,3 +11,4 @@
1011

1112
_running_server: Server | None = None
1213
_transport_object: TransportManager | None = None
14+
template_files = files("murfey") / "templates"

src/murfey/server/api/__init__.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
from fastapi.templating import Jinja2Templates
2+
3+
from murfey.server import template_files
4+
5+
templates = Jinja2Templates(template_files)

src/murfey/server/api/bootstrap.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import random
2121
import re
2222
import zipfile
23-
from importlib.resources import files
2423
from io import BytesIO
2524
from typing import Any
2625
from urllib.parse import quote
@@ -29,9 +28,9 @@
2928
import requests
3029
from fastapi import APIRouter, HTTPException, Query, Request, Response
3130
from fastapi.responses import FileResponse, HTMLResponse, StreamingResponse
32-
from fastapi.templating import Jinja2Templates
3331

3432
import murfey
33+
from murfey.server.api import templates
3534
from murfey.util.config import get_hostname, get_machine_config, get_microscope
3635

3736
tag = {
@@ -101,9 +100,6 @@ def get_version(client_version: str = ""):
101100
=======================================================================================
102101
"""
103102

104-
template_files = files("murfey") / "templates"
105-
templates = Jinja2Templates(directory=template_files)
106-
107103

108104
def respond_with_template(
109105
request: Request, filename: str, parameters: dict[str, Any] | None = None

src/murfey/server/api/session_info.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212

1313
import murfey.server.ispyb
1414
import murfey.server.websocket as ws
15-
from murfey.server import _transport_object, get_hostname, get_microscope, templates
15+
from murfey.server import _transport_object
16+
from murfey.server.api import templates
1617
from murfey.server.api.auth import MurfeySessionID, validate_token
1718
from murfey.server.api.shared import get_foil_hole as _get_foil_hole
1819
from murfey.server.api.shared import (
@@ -29,7 +30,12 @@
2930
)
3031
from murfey.server.murfey_db import murfey_db
3132
from murfey.util import sanitise
32-
from murfey.util.config import MachineConfig, get_machine_config
33+
from murfey.util.config import (
34+
MachineConfig,
35+
get_hostname,
36+
get_machine_config,
37+
get_microscope,
38+
)
3339
from murfey.util.db import (
3440
ClientEnvironment,
3541
DataCollection,

src/murfey/server/api/workflow.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,17 @@
2525
Image = None
2626

2727
import murfey.server.prometheus as prom
28-
from murfey.server import (
28+
from murfey.server import _transport_object
29+
from murfey.server.api.auth import MurfeySessionID, validate_token
30+
from murfey.server.api.spa import _cryolo_model_path
31+
from murfey.server.feedback import (
2932
_murfey_id,
30-
_transport_object,
3133
check_tilt_series_mc,
3234
get_all_tilts,
3335
get_angle,
3436
get_job_ids,
3537
get_tomo_proc_params,
3638
)
37-
from murfey.server.api.auth import MurfeySessionID, validate_token
38-
from murfey.server.api.spa import _cryolo_model_path
3939
from murfey.server.ispyb import DB, get_proposal_id
4040
from murfey.server.murfey_db import murfey_db
4141
from murfey.util import sanitise

src/murfey/server/main.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from __future__ import annotations
22

33
import logging
4-
import os
54

65
from backports.entry_points_selectable import entry_points
76
from fastapi import FastAPI
@@ -29,13 +28,6 @@
2928
from murfey.server import template_files
3029
from murfey.util.config import get_security_config
3130

32-
# Import Murfey server or demo server based on settings
33-
if os.getenv("MURFEY_DEMO"):
34-
from murfey.server.demo_api import router
35-
else:
36-
from murfey.server.api import router
37-
38-
3931
log = logging.getLogger("murfey.server.main")
4032

4133
tags_metadata = [murfey.server.api.bootstrap.tag]
@@ -66,7 +58,6 @@ class Settings(BaseSettings):
6658
app.mount("/images", StaticFiles(directory=template_files / "images"), name="images")
6759

6860
# Add router endpoints to the API
69-
app.include_router(router)
7061
app.include_router(murfey.server.api.bootstrap.version)
7162
app.include_router(murfey.server.api.bootstrap.bootstrap)
7263
app.include_router(murfey.server.api.bootstrap.cygwin)

src/murfey/workflows/spa/flush_spa_preprocess.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
from sqlalchemy.exc import NoResultFound
77
from sqlmodel import Session, select
88

9-
from murfey.server import _murfey_id, _transport_object
9+
from murfey.server import _transport_object
1010
from murfey.server.api.auth import MurfeySessionID
11+
from murfey.server.feedback import _murfey_id
1112
from murfey.util import sanitise, secure_path
1213
from murfey.util.config import get_machine_config, get_microscope
1314
from murfey.util.db import (

0 commit comments

Comments
 (0)