'.return_value' might not be neded when mocking class attribute

tieneupin · tieneupin · commit 9b4a6aceeb75 · 2025-02-13T11:29:39.000Z
diff --git a/tests/workflows/clem/test_align_and_merge.py b/tests/workflows/clem/test_align_and_merge.py
@@ -82,7 +82,7 @@ def test_submit_cluster_request(
 
     # Construct a mock MachineConfig object for use within the function
     mock_machine_config = MagicMock(spec=MachineConfig)
-    mock_machine_config.return_value.processed_directory_name = processed_folder
+    mock_machine_config.processed_directory_name = processed_folder
     mock_get_machine_config.return_value = {
         instrument_name: mock_machine_config,
     }

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ def test_submit_cluster_request(`
`82`	`82`
`83`	`83`	`# Construct a mock MachineConfig object for use within the function`
`84`	`84`	`mock_machine_config = MagicMock(spec=MachineConfig)`
`85`		`- mock_machine_config.return_value.processed_directory_name = processed_folder`
	`85`	`+ mock_machine_config.processed_directory_name = processed_folder`
`86`	`86`	`mock_get_machine_config.return_value = {`
`87`	`87`	`instrument_name: mock_machine_config,`
`88`	`88`	`}`