Skip to content

Commit 9ba6410

Browse files
committed
Moved 'sanitise()' and 'sanitise_path()' from 'murfey.server.__init__' to 'murfey.util.__init__'
1 parent 8f3bfe1 commit 9ba6410

File tree

12 files changed

+19
-30
lines changed

12 files changed

+19
-30
lines changed

src/murfey/server/__init__.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
)
4141
from sqlalchemy.orm.exc import ObjectDeletedError
4242
from sqlmodel import Session, create_engine, select
43-
from werkzeug.utils import secure_filename
4443
from workflows import Error as WorkflowsError
4544
from workflows.transport.pika_transport import PikaTransport
4645

@@ -49,7 +48,7 @@
4948
import murfey.util.db as db
5049
from murfey.server.ispyb import ISPyBSession, get_session_id
5150
from murfey.server.murfey_db import url # murfey_db
52-
from murfey.util import LogFilter
51+
from murfey.util import LogFilter, sanitise
5352
from murfey.util.config import (
5453
MachineConfig,
5554
get_hostname,
@@ -94,14 +93,6 @@ class JobIDs(NamedTuple):
9493
appid: int
9594

9695

97-
def sanitise(in_string: str) -> str:
98-
return in_string.replace("\r\n", "").replace("\n", "")
99-
100-
101-
def sanitise_path(in_path: Path) -> Path:
102-
return Path("/".join(secure_filename(p) for p in in_path.parts))
103-
104-
10596
def get_angle(tilt_file_name: str) -> float:
10697
for p in Path(tilt_file_name).name.split("_"):
10798
if "." in p:

src/murfey/server/api/auth.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
from pydantic import BaseModel
1717
from sqlmodel import Session, create_engine, select
1818

19-
from murfey.server import sanitise
2019
from murfey.server.murfey_db import murfey_db, url
20+
from murfey.util import sanitise
2121
from murfey.util.config import get_security_config
2222
from murfey.util.db import MurfeyUser as User
2323
from murfey.util.db import Session as MurfeySession

src/murfey/server/api/bootstrap.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
from fastapi.responses import FileResponse, HTMLResponse, StreamingResponse
3030

3131
import murfey
32-
from murfey.server import get_machine_config, respond_with_template
32+
from murfey.server import respond_with_template
33+
from murfey.util.config import get_machine_config
3334

3435
tag = {
3536
"name": "bootstrap",

src/murfey/server/api/file_manip.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@
88
from sqlmodel import select
99
from werkzeug.utils import secure_filename
1010

11-
from murfey.server import sanitise
1211
from murfey.server.api.auth import MurfeySessionID, validate_token
1312
from murfey.server.gain import Camera, prepare_eer_gain, prepare_gain
1413
from murfey.server.murfey_db import murfey_db
15-
from murfey.util import secure_path
14+
from murfey.util import sanitise, secure_path
1615
from murfey.util.config import get_machine_config
1716
from murfey.util.db import Session, SessionProcessingParameters
1817
from murfey.util.eer import num_frames

src/murfey/server/api/instrument.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
from sqlmodel import select
1313
from werkzeug.utils import secure_filename
1414

15-
from murfey.server import sanitise
1615
from murfey.server.api.auth import (
1716
MurfeySessionID,
1817
create_access_token,
@@ -21,7 +20,7 @@
2120
validate_token,
2221
)
2322
from murfey.server.murfey_db import murfey_db
24-
from murfey.util import secure_path
23+
from murfey.util import sanitise, secure_path
2524
from murfey.util.config import get_machine_config
2625
from murfey.util.db import RsyncInstance, Session, SessionProcessingParameters
2726
from murfey.util.models import File, MultigridWatcherSetup

src/murfey/server/api/prometheus.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
from sqlmodel import select
55

66
import murfey.server.prometheus as prom
7-
from murfey.server import sanitise
87
from murfey.server.api.auth import validate_token
98
from murfey.server.murfey_db import murfey_db
9+
from murfey.util import sanitise
1010
from murfey.util.db import RsyncInstance
1111
from murfey.util.models import RsyncerInfo
1212

src/murfey/server/api/session_control.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from murfey.server.ispyb import DB
1818
except ImportError:
1919
DB = None
20-
from murfey.server import _transport_object, sanitise
20+
from murfey.server import _transport_object
2121
from murfey.server.api.auth import MurfeySessionID, validate_token
2222
from murfey.server.api.shared import get_foil_hole as _get_foil_hole
2323
from murfey.server.api.shared import (
@@ -33,6 +33,7 @@
3333
remove_session_by_id,
3434
)
3535
from murfey.server.murfey_db import murfey_db
36+
from murfey.util import sanitise
3637
from murfey.util.config import MachineConfig, get_machine_config
3738
from murfey.util.db import (
3839
AutoProcProgram,

src/murfey/server/api/session_info.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,7 @@
1212

1313
import murfey.server.ispyb
1414
import murfey.server.websocket as ws
15-
from murfey.server import (
16-
_transport_object,
17-
get_hostname,
18-
get_microscope,
19-
sanitise,
20-
templates,
21-
)
15+
from murfey.server import _transport_object, get_hostname, get_microscope, templates
2216
from murfey.server.api.auth import MurfeySessionID, validate_token
2317
from murfey.server.api.shared import get_foil_hole as _get_foil_hole
2418
from murfey.server.api.shared import (
@@ -34,6 +28,7 @@
3428
remove_session_by_id,
3529
)
3630
from murfey.server.murfey_db import murfey_db
31+
from murfey.util import sanitise
3732
from murfey.util.config import MachineConfig, get_machine_config
3833
from murfey.util.db import (
3934
ClientEnvironment,

src/murfey/server/api/shared.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
from werkzeug.utils import secure_filename
88

99
import murfey.server.prometheus as prom
10-
from murfey.server import sanitise
11-
from murfey.util import safe_run
10+
from murfey.util import safe_run, sanitise
1211
from murfey.util.config import MachineConfig, from_file, get_machine_config, settings
1312
from murfey.util.db import (
1413
DataCollection,

src/murfey/server/api/workflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@
3333
get_angle,
3434
get_job_ids,
3535
get_tomo_proc_params,
36-
sanitise,
3736
)
3837
from murfey.server.api.auth import MurfeySessionID, validate_token
3938
from murfey.server.api.spa import _cryolo_model_path
4039
from murfey.server.ispyb import DB, get_proposal_id
4140
from murfey.server.murfey_db import murfey_db
41+
from murfey.util import sanitise
4242
from murfey.util.config import get_machine_config
4343
from murfey.util.db import (
4444
AutoProcProgram,

0 commit comments

Comments
 (0)