Mock as return value

stephen-riggs · stephen-riggs · commit dc35e9f0e59e · 2025-11-26T10:02:13.000Z
diff --git a/tests/server/test_ispyb.py b/tests/server/test_ispyb.py
@@ -99,7 +99,7 @@ def test_update_data_collection_group(mock_transport, ispyb_db_session: Session)
     )
 
     transport_manager = TransportManager("PikaTransport")
-    with mock.patch("murfey.server.ispyb.ISPyBSession", ispyb_db_session):
+    with mock.patch("murfey.server.ispyb.ISPyBSession", return_value=ispyb_db_session):
         transport_manager.do_update_data_collection_group(
             record=DataCollectionGroup(dataCollectionGroupId=1, experimentTypeId=2)
         )

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ def test_update_data_collection_group(mock_transport, ispyb_db_session: Session)`
`99`	`99`	`)`
`100`	`100`
`101`	`101`	`transport_manager = TransportManager("PikaTransport")`
`102`		`- with mock.patch("murfey.server.ispyb.ISPyBSession", ispyb_db_session):`
	`102`	`+ with mock.patch("murfey.server.ispyb.ISPyBSession", return_value=ispyb_db_session):`
`103`	`103`	`transport_manager.do_update_data_collection_group(`
`104`	`104`	`record=DataCollectionGroup(dataCollectionGroupId=1, experimentTypeId=2)`
`105`	`105`	`)`