Skip to content

Commit ef2ed31

Browse files
committed
Some typing issues in the manifest
1 parent 49438b0 commit ef2ed31

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/murfey/server/api/workflow.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,10 @@ class DCGroupParameters(BaseModel):
9494
"/visits/{visit_name}/sessions/{session_id}/register_data_collection_group"
9595
)
9696
def register_dc_group(
97-
visit_name, session_id: MurfeySessionID, dcg_params: DCGroupParameters, db=murfey_db
97+
visit_name: str,
98+
session_id: MurfeySessionID,
99+
dcg_params: DCGroupParameters,
100+
db=murfey_db,
98101
):
99102
ispyb_proposal_code = visit_name[:2]
100103
ispyb_proposal_number = visit_name.split("-")[0][2:]
@@ -201,7 +204,7 @@ class DCParameters(BaseModel):
201204

202205
@router.post("/visits/{visit_name}/sessions/{session_id}/start_data_collection")
203206
def start_dc(
204-
visit_name, session_id: MurfeySessionID, dc_params: DCParameters, db=murfey_db
207+
visit_name: str, session_id: MurfeySessionID, dc_params: DCParameters, db=murfey_db
205208
):
206209
ispyb_proposal_code = visit_name[:2]
207210
ispyb_proposal_number = visit_name.split("-")[0][2:]

src/murfey/util/route_manifest.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1187,7 +1187,7 @@ murfey.server.api.websocket.ws:
11871187
function: websocket_connection_endpoint
11881188
path_params:
11891189
- name: client_id
1190-
type: Union
1190+
type: typing.Union[int, str]
11911191
methods: []
11921192
- path: /ws/test/{client_id}
11931193
function: close_ws_connection
@@ -1200,7 +1200,7 @@ murfey.server.api.websocket.ws:
12001200
function: close_unrecorded_ws_connection
12011201
path_params:
12021202
- name: client_id
1203-
type: Union
1203+
type: typing.Union[int, str]
12041204
methods:
12051205
- DELETE
12061206
murfey.server.api.workflow.correlative_router:
@@ -1255,7 +1255,7 @@ murfey.server.api.workflow.router:
12551255
function: register_dc_group
12561256
path_params:
12571257
- name: visit_name
1258-
type: Any
1258+
type: str
12591259
- name: session_id
12601260
type: int
12611261
methods:
@@ -1264,7 +1264,7 @@ murfey.server.api.workflow.router:
12641264
function: start_dc
12651265
path_params:
12661266
- name: visit_name
1267-
type: Any
1267+
type: str
12681268
- name: session_id
12691269
type: int
12701270
methods:

0 commit comments

Comments
 (0)