Skip to content

Commit f42b0f0

Browse files
committed
Pass images as individual list items in the subprocess command
1 parent db637c8 commit f42b0f0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/cli/test_build_images.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def test_run(
5555
# Set up the command based on what these values are
5656
build_cmd = [
5757
"murfey.build_images",
58-
" ".join(images),
58+
*images,
5959
]
6060

6161
# Iterate through flags and add them according to the command
@@ -87,16 +87,16 @@ def test_run(
8787
mock_subprocess.return_value = 0
8888

8989
# Mock 'build_image' return values
90-
image_paths = [
90+
built_images = [
9191
f"{dst if dst else def_dst}/{image[0]}:{tags[0] if tags else def_tags[0]}"
9292
for image in images
9393
]
94-
mock_build.side_effect = image_paths
94+
mock_build.side_effect = built_images
9595

9696
# Mock all the return values when tagging the images
9797
all_tags = [
9898
f"{image.split(':')[0]}:{tag}"
99-
for image in image_paths
99+
for image in built_images
100100
for tag in (tags if tags else def_tags)
101101
]
102102
mock_tag.side_effect = all_tags

0 commit comments

Comments
 (0)