Add tests for debug deprecation

update existing tests

Author: Anthchirp

tests/test_procrunner.py

@@ -42,7 +42,7 @@ def test_run_command_aborts_after_timeout(
     task = ["___"]
 
     with pytest.raises(RuntimeError):
-        procrunner.run(task, timeout=-1, debug=False, raise_timeout_exception=True)
+        procrunner.run(task, timeout=-1, raise_timeout_exception=True)
 
     assert mock_subprocess.Popen.called
     assert mock_process.terminate.called
@@ -84,7 +84,6 @@ def streamreader_processing(*args, **kwargs):
     actual = procrunner.run(
         command,
         timeout=0.5,
-        debug=False,
         callback_stdout=mock.sentinel.callback_stdout,
         callback_stderr=mock.sentinel.callback_stderr,
         working_directory=mock.sentinel.cwd,
@@ -99,14 +98,14 @@ def streamreader_processing(*args, **kwargs):
             mock.call(
                 stream_stdout,
                 output=mock.ANY,
-                debug=mock.ANY,
+                debug=None,
                 notify=mock.ANY,
                 callback=mock.sentinel.callback_stdout,
             ),
             mock.call(
                 stream_stderr,
                 output=mock.ANY,
-                debug=mock.ANY,
+                debug=None,
                 notify=mock.ANY,
                 callback=mock.sentinel.callback_stderr,
             ),
@@ -128,12 +127,21 @@ def streamreader_processing(*args, **kwargs):
 def test_default_process_environment_is_parent_environment(mock_subprocess):
     mock_subprocess.Popen.side_effect = NotImplementedError()  # cut calls short
     with pytest.raises(NotImplementedError):
-        procrunner.run(
-            [mock.Mock()], timeout=-1, debug=False, raise_timeout_exception=True
-        )
+        procrunner.run([mock.Mock()], timeout=-1, raise_timeout_exception=True)
     assert mock_subprocess.Popen.call_args[1]["env"] == os.environ
 
 
+@mock.patch("procrunner.subprocess")
+def test_using_debug_parameter_raises_warning(mock_subprocess):
+    mock_subprocess.Popen.side_effect = NotImplementedError()  # cut calls short
+    with pytest.warns(DeprecationWarning, match="debug"):
+        with pytest.raises(NotImplementedError):
+            procrunner.run([mock.Mock()], debug=True)
+    with pytest.warns(DeprecationWarning, match="debug"):
+        with pytest.raises(NotImplementedError):
+            procrunner.run([mock.Mock()], debug=False)
+
+
 @mock.patch("procrunner.subprocess")
 def test_pass_custom_environment_to_process(mock_subprocess):
     mock_subprocess.Popen.side_effect = NotImplementedError()  # cut calls short
@@ -143,7 +151,6 @@ def test_pass_custom_environment_to_process(mock_subprocess):
         procrunner.run(
             [mock.Mock()],
             timeout=-1,
-            debug=False,
             environment=copy.copy(mock_env),
             raise_timeout_exception=True,
         )
@@ -160,7 +167,6 @@ def test_pass_custom_environment_to_process_and_add_another_value(mock_subproces
         procrunner.run(
             [mock.Mock()],
             timeout=-1,
-            debug=False,
             environment=copy.copy(mock_env1),
             environment_override=copy.copy(mock_env2),
             raise_timeout_exception=True,
@@ -178,7 +184,6 @@ def test_use_default_process_environment_and_add_another_value(mock_subprocess):
         procrunner.run(
             [mock.Mock()],
             timeout=-1,
-            debug=False,
             environment_override=copy.copy(mock_env2),
             raise_timeout_exception=True,
         )
@@ -207,7 +212,6 @@ def test_use_default_process_environment_and_override_a_value(mock_subprocess):
         procrunner.run(
             [mock.Mock()],
             timeout=-1,
-            debug=False,
             environment_override={
                 random_environment_variable: "X" + random_environment_value
             },