Skip to content

Commit c5848f5

Browse files
committed
Fix 'Implicit Optional' typing errors
1 parent 5765777 commit c5848f5

File tree

3 files changed

+24
-10
lines changed

3 files changed

+24
-10
lines changed

src/zocalo/cli/dlq_check.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@
1414
#
1515

1616

17-
def check_dlq(zc: zocalo.configuration.Configuration, namespace: str = None) -> dict:
17+
def check_dlq(
18+
zc: zocalo.configuration.Configuration, namespace: str | None = None
19+
) -> dict:
1820
"""Monitor ActiveMQ queue activity."""
1921
jmx = JMXAPI(zc)
2022
if namespace:
@@ -48,7 +50,7 @@ def extract_queue_name(namestring):
4850

4951

5052
def check_dlq_rabbitmq(
51-
zc: zocalo.configuration.Configuration, namespace: str = None
53+
zc: zocalo.configuration.Configuration, namespace: str | None = None
5254
) -> dict:
5355
rmq = RabbitMQAPI.from_zocalo_configuration(zc)
5456
return {

src/zocalo/util/rabbitmq.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,10 @@ def health_checks(self) -> Tuple[Dict[str, Any], Dict[str, str]]:
706706
return success, failure
707707

708708
def get(
709-
self, endpoint: str, params: Dict[str, Any] = None, timeout: float | None = None
709+
self,
710+
endpoint: str,
711+
params: Dict[str, Any] | None = None,
712+
timeout: float | None = None,
710713
) -> requests.Response:
711714
return self._session.get(
712715
f"{self._url}/{endpoint}", params=params, timeout=timeout
@@ -715,8 +718,8 @@ def get(
715718
def put(
716719
self,
717720
endpoint: str,
718-
params: Dict[str, Any] = None,
719-
json: Dict[str, Any] = None,
721+
params: Dict[str, Any] | None = None,
722+
json: Dict[str, Any] | None = None,
720723
timeout: float | None = None,
721724
) -> requests.Response:
722725
return self._session.put(
@@ -735,7 +738,10 @@ def post(
735738
)
736739

737740
def delete(
738-
self, endpoint: str, params: Dict[str, Any] = None, timeout: float | None = None
741+
self,
742+
endpoint: str,
743+
params: Dict[str, Any] | None = None,
744+
timeout: float | None = None,
739745
) -> requests.Response:
740746
return self._session.delete(
741747
f"{self._url}/{endpoint}", params=params, timeout=timeout

src/zocalo/util/slurm/__init__.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ def from_zocalo_configuration(cls, zc: zocalo.configuration.Configuration):
4444
)
4545

4646
def get(
47-
self, endpoint: str, params: dict[str, Any] = None, timeout: float | None = None
47+
self,
48+
endpoint: str,
49+
params: dict[str, Any] | None = None,
50+
timeout: float | None = None,
4851
) -> requests.Response:
4952
response = self.session.get(
5053
f"{self.url}/{endpoint}", params=params, timeout=timeout
@@ -55,8 +58,8 @@ def get(
5558
def put(
5659
self,
5760
endpoint: str,
58-
params: dict[str, Any] = None,
59-
json: dict[str, Any] = None,
61+
params: dict[str, Any] | None = None,
62+
json: dict[str, Any] | None = None,
6063
timeout: float | None = None,
6164
) -> requests.Response:
6265
response = self.session.put(
@@ -79,7 +82,10 @@ def post(
7982
return response
8083

8184
def delete(
82-
self, endpoint: str, params: dict[str, Any] = None, timeout: float | None = None
85+
self,
86+
endpoint: str,
87+
params: dict[str, Any] | None = None,
88+
timeout: float | None = None,
8389
) -> requests.Response:
8490
response = self.session.delete(
8591
f"{self.url}/{endpoint}", params=params, timeout=timeout

0 commit comments

Comments
 (0)