|
1 | 1 | Contributing |
2 | 2 | ============ |
3 | 3 |
|
4 | | -Contributions and issues are most welcome! All issues and pull requests are |
5 | | -handled through Github_. Also, please check for any existing issues before |
6 | | -filing a new one. If you have a great idea but it involves big changes, please |
7 | | -file a ticket before making a pull request! We want to make sure you don't spend |
8 | | -your time coding something that might not fit the scope of the project. |
| 4 | +Contributing to the skeleton repository is different to other repos. There |
| 5 | +are two sorts of contributions: |
9 | 6 |
|
10 | | -.. _Github: https://github.com/dls-controls/dls-python3-skeleton/issues |
| 7 | +- Changes to the skeleton structure should be made on a branch, then a |
| 8 | + PR_ raised back to the ``skeleton`` branch. |
| 9 | +- Changes to the docs or commandline tool should be made directly on master |
| 10 | + |
| 11 | +.. _PR: https://github.com/dls-controls/dls-python3-skeleton/pulls |
11 | 12 |
|
12 | 13 | Running the tests |
13 | 14 | ----------------- |
14 | 15 |
|
15 | | -To get the source source code and run the unit tests, run:: |
| 16 | +Both the ``skeleton`` and ``master`` branch have different tests, but |
| 17 | +the process to run them is the same:: |
16 | 18 |
|
17 | 19 | $ git clone git://github.com/dls-controls/dls-python3-skeleton.git |
18 | 20 | $ cd dls-python3-skeleton |
19 | 21 | $ pipenv install --dev |
20 | 22 | $ pipenv run tests |
21 | 23 |
|
22 | | -While 100% code coverage does not make a library bug-free, it significantly |
23 | | -reduces the number of easily caught bugs! Please make sure coverage remains the |
24 | | -same or is improved by a pull request! |
| 24 | +Please note that Pipfile.lock is only committed on ``master``, not on |
| 25 | +``skeleton`` |
25 | 26 |
|
26 | 27 | Code Styling |
27 | 28 | ------------ |
@@ -74,27 +75,13 @@ You can build the docs from the project directory by running:: |
74 | 75 | Release Process |
75 | 76 | --------------- |
76 | 77 |
|
77 | | -To make a new release, please follow this checklist: |
| 78 | +Releases are only made when the commandline tool needs to be released. |
| 79 | +When this happens: |
78 | 80 |
|
79 | 81 | - Choose a new PEP440 compliant release number |
80 | | -- Add a release note in CHANGELOG.rst |
81 | 82 | - Git tag the version |
82 | 83 | - Push to github and the actions will make a release on pypi |
83 | 84 | - Push to internal gitlab and do a dls-release.py of the tag |
84 | 85 |
|
85 | | -Updating the tools |
86 | | ------------------- |
87 | | - |
88 | | -This module is merged with the dls-python3-skeleton_. This is a generic |
89 | | -Python project structure which provides a means to keep tools and |
90 | | -techniques in sync between multiple Python projects. To update to the |
91 | | -latest version of the skeleton, run:: |
92 | | - |
93 | | - $ git pull https://github.com/dls-controls/dls-python3-skeleton |
94 | | - |
95 | | -Any merge conflicts will indicate an area where something has changed that |
96 | | -conflicts with the setup of the current module. Check the `closed pull requests |
97 | | -<https://github.com/dls-controls/dls-python3-skeleton/pulls?q=is%3Apr+is%3Aclosed>`_ |
98 | | -of the skeleton module for more details. |
99 | | - |
100 | | -.. _dls-python3-skeleton: https://dls-controls.github.io/dls-python3-skeleton |
| 86 | +Apart from this, ``master`` and ``skeleton`` should always be deployable, |
| 87 | +and are considered the latest release. |
0 commit comments