Skip to content

Commit 1a2fb2b

Browse files
authored
Merge pull request #30 from dls-controls/changelog
Make github changelog canonical
2 parents a558b5a + 2e00d15 commit 1a2fb2b

File tree

7 files changed

+22
-16
lines changed

7 files changed

+22
-16
lines changed

.github/workflows/code.yml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
run: flake8
2424

2525
build:
26-
name: ${{ matrix.os }}/${{ matrix.python }}
26+
name: build/${{ matrix.os }}/${{ matrix.python }}
2727
runs-on: ${{ matrix.os }}
2828

2929
strategy:
@@ -106,22 +106,29 @@ jobs:
106106
name: ${{ matrix.os }}/${{ matrix.python }}
107107
directory: dist
108108

109-
upload_pypi:
109+
release:
110110
needs: [build]
111111
runs-on: ubuntu-latest
112-
# upload to PyPI on every tag
112+
# upload to PyPI and make a release on every tag
113113
if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags')
114114
steps:
115115
- uses: actions/download-artifact@v2
116116
with:
117117
name: dist
118118
path: dist
119119

120-
- name: Install Python Dependencies
121-
run: pip install twine
120+
- name: Github Release
121+
# We pin to the SHA, not the tag, for security reasons.
122+
# https://docs.github.com/en/actions/learn-github-actions/security-hardening-for-github-actions#using-third-party-actions
123+
uses: softprops/action-gh-release@2d72d869af3bf23602f9593a1e3fd739b80ac1eb # v0.1.12
124+
with:
125+
files: dist/*
126+
body: See [Changelog](CHANGELOG.rst) for more details
127+
env:
128+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
122129

123130
- name: Publish to PyPI
124131
env:
125132
TWINE_USERNAME: __token__
126133
TWINE_PASSWORD: ${{ secrets.pypi_token }}
127-
run: twine upload dist/*
134+
run: pipx run twine upload dist/*

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
# Only master and tags are published
4545
if: "${{ github.repository_owner == 'dls-controls' && (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags')) }}"
4646
# We pin to the SHA, not the tag, for security reasons.
47-
# https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/security-hardening-for-github-actions#using-third-party-actions
47+
# https://docs.github.com/en/actions/learn-github-actions/security-hardening-for-github-actions#using-third-party-actions
4848
uses: peaceiris/actions-gh-pages@bbdfb200618d235585ad98e965f4aafc39b4c501 # v3.7.3
4949
with:
5050
github_token: ${{ secrets.GITHUB_TOKEN }}

CONTRIBUTING.rst

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,10 @@ You can build the docs from the project directory by running::
6666
Release Process
6767
---------------
6868

69-
To make a new release, please go through the following checklist:
69+
To make a new release, please follow this checklist:
7070

7171
- Choose a new PEP440 compliant release number
72-
- Git tag the version with a message summarizing the changes
72+
- Add a release note in CHANGELOG.rst
73+
- Git tag the version
7374
- Push to github and the actions will make a release on pypi
74-
- Push to internal gitlab but do not release from there
75-
- Run ``dls-py3 download-one-dependency softioc <release>``
76-
- Run ``cp Pipfile.lock /dls_sw/work/python3/RHEL7-x86_64/distributions/softioc-<release>.Pipfile.lock``
77-
- Run ``dls-release.py -a python3ext softioc <release>``
75+
- Push to internal gitlab and do a dls-release.py of the tag

README.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ asyncio for concurrency. PVs are served over Channel Access and PVAccess.
1313
PyPI ``pip install softioc``
1414
Source code https://github.com/dls-controls/pythonSoftIOC
1515
Documentation https://dls-controls.github.io/pythonSoftIOC
16+
Changelog https://github.com/dls-controls/pythonSoftIOC/blob/master/CHANGELOG.rst
1617
============== ==============================================================
1718

1819
A simple example of the use of this library:

docs/_templates/layout.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99
{{ super() }}
1010
<!-- Include Index in the sidebar -->
1111
<!-- https://stackoverflow.com/a/37843854 -->
12-
<a href="{{pathto('genindex.html', 1)}}">Index</a>
12+
<a href="{{ pathto('genindex.html', 1) }}">Index</a>
13+
<!-- Include link to changelog too -->
14+
<a href="https://github.com/dls-controls/{{ project }}/blob/master/CHANGELOG.rst">Changelog</a>
1315
<!-- Add versions for selected branches + tags -->
1416
<p class="caption"><span class="caption-text">Versions</span></p>
1517
<ul id="versions"/>

docs/index.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ Table Of Contents
7979
:maxdepth: 1
8080

8181
reference/api
82-
reference/changelog
8382
reference/contributing
8483

8584
* :ref:`genindex`

docs/reference/changelog.rst

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)