Change default alarm values

This ensures we only set INVALID_ALARM+UDF_ALARM when there is no value,
but otherwise both the severity and the status are set to NO_ALARM

Author: AlexanderWells-diamond

docs/reference/api.rst

@@ -550,7 +550,7 @@ class which provides the methods documented below.
     This class is used to implement Python device support for the record types
     ``ai``, ``bi``, ``longin``, ``mbbi`` and IN ``waveform`` records.
 
-    ..  method:: set(value, severity=NO_ALARM, alarm=UDF_ALARM, timestamp=None)
+    ..  method:: set(value, severity=NO_ALARM, alarm=NO_ALARM, timestamp=None)
 
         Updates the stored value and severity status and triggers an update.  If
         ``SCAN`` has been set to ``'I/O Intr'`` (which is the default if the
@@ -609,7 +609,7 @@ Working with OUT records
     ``ao``, ``bo``, ``longout``, ``mbbo`` and OUT ``waveform`` records.  All OUT
     records support the following methods.
 
-    ..  method:: set(value, process=True, severity=NO_ALARM, alarm=UDF_ALARM)
+    ..  method:: set(value, process=True, severity=NO_ALARM, alarm=NO_ALARM)
 
         Updates the stored value and severity status.  By default this will
         trigger record processing, and so will cause any associated `on_update`

softioc/device.py

@@ -137,7 +137,7 @@ def _process(self, record):
         return self._epics_rc_
 
     def set(self, value,
-            severity=alarm.NO_ALARM, alarm=alarm.UDF_ALARM, timestamp=None):
+            severity=alarm.NO_ALARM, alarm=alarm.NO_ALARM, timestamp=None):
         '''Updates the stored value and triggers an update.  The alarm
         severity and timestamp can also be specified if appropriate.'''
         value = self._value_to_epics(value)
@@ -177,14 +177,16 @@ def __init__(self, name, **kargs):
 
         if 'initial_value' in kargs:
             value = self._value_to_epics(kargs.pop('initial_value'))
-            initial_alarm = alarm.NO_ALARM
+            initial_severity = alarm.NO_ALARM
+            initial_status = alarm.NO_ALARM
         else:
             value = None
             # To maintain backwards compatibility, if there is no initial value
             # we mark the record as invalid
-            initial_alarm = alarm.INVALID_ALARM
+            initial_severity = alarm.INVALID_ALARM
+            initial_status = alarm.UDF_ALARM
 
-        self._value = (value, initial_alarm, alarm.UDF_ALARM)
+        self._value = (value, initial_severity, initial_status)
 
         self._blocking = kargs.pop('blocking', blocking)
         if self._blocking:
@@ -274,7 +276,7 @@ def set_alarm(self, severity, alarm):
 
 
     def set(self, value, process=True,
-            severity=alarm.NO_ALARM, alarm=alarm.UDF_ALARM):
+            severity=alarm.NO_ALARM, alarm=alarm.NO_ALARM):
         '''Special routine to set the value directly.'''
         value = self._value_to_epics(value)
         try: