Default DISP to TRUE for all In records

Author: AlexanderWells-diamond

CHANGELOG.rst

@@ -12,6 +12,7 @@ Unreleased_
 Changed:
 
 - `Remove python2 support <../../pull/64>`
+- `Default DISP to TRUE for all In records <../../pull/74>`
 
 3.2.1_ - 2021-11-25
 -------------------

softioc/builder.py

@@ -18,12 +18,13 @@
 
 
 def _in_record(record, name, **fields):
-    '''For input records we provide some automatic extra features: scanning
-    and initialisation as appropriate.'''
+    '''For input records we provide some automatic extra features: scanning,
+    initialisation as appropriate, and blocking puts from outside the IOC.'''
 
     fields.setdefault('SCAN', 'I/O Intr')
     if 'initial_value' in fields:
         fields.setdefault('PINI', 'YES')
+    fields.setdefault('DISP', 1)
     return getattr(PythonDevice, record)(name, **fields)
 
 

tests/test_records.py

@@ -18,3 +18,36 @@ def test_enum_length_restriction():
                 "ManyLabels", "one", "two", "three", "four", "five", "six",
                 "seven", "eight", "nine", "ten", "eleven", "twelve", "thirteen",
                 "fourteen", "fifteen", "sixteen", "seventeen")
+
+def test_DISP_defaults_on():
+    """Test that all IN record types have DISP=1 set by default"""
+    in_records = [
+        builder.aIn,
+        builder.boolIn,
+        builder.longIn,
+        builder.mbbIn,
+        builder.stringIn,
+        builder.WaveformIn,
+    ]
+
+    record_counter = 0
+
+    for creation_func in in_records:
+        kwargs = {}
+        record_counter += 1
+        record_name = "DISP" + str(record_counter)
+
+        if creation_func == builder.WaveformIn:
+            kwargs = {"length": 1}
+
+        record = creation_func(record_name, **kwargs)
+
+        # Note: DISP attribute won't exist if field not specified
+        assert record.DISP.Value() == 1
+
+def test_DISP_can_be_overridden():
+    """Test that DISP can be forced off for In records"""
+
+    record = builder.longIn("DISP-OFF", DISP=0)
+    # Note: DISP attribute won't exist if field not specified
+    assert record.DISP.Value() == 0