Implement code review comments

Author: AlexanderWells-diamond

softioc/extension.c

@@ -122,11 +122,12 @@ static PyObject *db_get_field(PyObject *self, PyObject *args)
     if (!PyArg_ParseTuple(args, "shnl", &name, &dbrType, &pbuffer, &length))
         return NULL;
 
-    long options = 0;
     struct dbAddr dbAddr;
     if (dbNameToAddr(name, &dbAddr))
         return PyErr_Format(
             PyExc_RuntimeError, "dbNameToAddr failed for %s", name);
+
+    long options = 0;
     if (dbGetField(&dbAddr, dbrType, pbuffer, &options, &length, NULL))
         return PyErr_Format(
             PyExc_RuntimeError, "dbGetField failed for %s", name);

softioc/imports.py

@@ -20,11 +20,11 @@ def get_field_offsets(record_type):
     return _extension.get_field_offsets(record_type)
 
 def db_put_field(name, dbr_type, pbuffer, length):
-    '''Put field where pbuffer is void* pointer. Returns RC'''
+    '''Put field where pbuffer is void* pointer. Returns None.'''
     return _extension.db_put_field(name, dbr_type, pbuffer, length)
 
 def db_get_field(name, dbr_type, pbuffer, length):
-    '''Get field where pbuffer is void* pointer. Returns Py_RETURN_NONE'''
+    '''Get field where pbuffer is void* pointer. Returns None.'''
     return _extension.db_get_field(name, dbr_type, pbuffer, length)
 
 def install_pv_logging(acf_file):