fixes context and better comments in direct_poll

Author: David Erb

src/rockingester_lib/collectors/context.py

@@ -62,17 +62,21 @@ async def aenter(self) -> None:
             await self.server.activate()
 
     # ----------------------------------------------------------------------------------------
-    async def aexit(self, type, value, traceback) -> None:
+    async def aexit(self, type=None, value=None, traceback=None):
         """
         Asyncio context exit.
 
         Stop service if one was started and releases any client resources.
         """
+        logger.debug(f"[DISSHU] {thing_type} aexit")
 
         if self.server is not None:
             if self.context_specification.get("start_as") == "process":
-                # Put in request to shutdown the server.
-                await self.server.client_shutdown()
+                # The server associated with this context is running?
+                if await self.is_process_alive():
+                    logger.debug(f"[DISSHU] {thing_type} calling client_shutdown")
+                    # Put in request to shutdown the server.
+                    await self.server.client_shutdown()
 
             if self.context_specification.get("start_as") == "coro":
                 await self.server.direct_shutdown()

src/rockingester_lib/collectors/direct_poll.py

@@ -183,7 +183,9 @@ async def tick(self) -> None:
     # ----------------------------------------------------------------------------------------
     async def scrape_plates_directories(self) -> None:
         """
-        Scrape all the configured directories looking for new files.
+        Scrape all the configured directories looking in each one for new plate directories.
+
+        Normally there is only one in the configured list of these places where plates arrive.
         """
 
         # TODO: Use asyncio tasks to paralellize scraping plates directories.
@@ -268,10 +270,7 @@ async def scrape_plate_directory(
             self.__visits_directory,
         )
 
-        logger.debug(
-            f"[CRYERR] for plate_barcode {plate_barcode} crystal_plate_model.error is {crystal_plate_model.error}"
-        )
-
+        # The model has not been marked as being in error?
         if crystal_plate_model.error is None:
             visit_directory = get_xchem_directory(
                 self.__visits_directory, crystal_plate_model.visit
@@ -283,8 +282,14 @@ async def scrape_plate_directory(
                 crystal_plate_model,
                 visit_directory,
             )
+
+        # The model has been marked as being in error?
         else:
-            # Remember we "handled" this one.
+            logger.debug(
+                f"[ROCKDIR] for plate_barcode {plate_barcode} crystal_plate_model.error is: {crystal_plate_model.error}"
+            )
+            # Remember we "handled" this one within the current instance.
+            # Keeping this list could be obviated if we could move the files out of the plates directory after we process them.
             self.__handled_plate_names.append(plate_name)
 
     # ----------------------------------------------------------------------------------------
@@ -318,7 +323,7 @@ async def scrape_plate_directory_if_complete(
         if target.is_dir():
             # Presumably this is done, so no error but log it.
             logger.debug(
-                f"[ROCKDIR] plate_barcode {plate_directory.name} is apparently already copied to {target}"
+                f"[ROCKDIR] plate directory {plate_directory.name} is apparently already copied to {target}"
             )
             self.__handled_plate_names.append(plate_directory.stem)
             return