Skip to content

Commit 4d8a309

Browse files
authored
Use paginate function from lims-utils (#12)
* Use paginate function from lims-utils * Revert Expeye access changes
1 parent 2bbcb49 commit 4d8a309

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

src/scaup/crud/containers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from ..models.containers import ContainerIn, ContainerOut, OptionalContainer
77
from ..models.inner_db.tables import Container, Sample, Shipment
88
from ..utils.crud import assert_not_booked, edit_item
9-
from ..utils.database import inner_db, paginate
9+
from ..utils.database import inner_db
1010
from ..utils.session import retry_if_exists
1111

1212

@@ -81,7 +81,7 @@ def get_containers(
8181
if container_type:
8282
query = query.filter(Container.type == container_type)
8383

84-
return paginate(query, limit, page, slow_count=True, scalar=False)
84+
return inner_db.paginate(query, limit, page, slow_count=True, scalar=False)
8585

8686

8787
def update_container(

src/scaup/crud/internal.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from ..models.inner_db.tables import Container, TopLevelContainer
55
from ..models.shipments import ShipmentChildren
66
from ..models.top_level_containers import TopLevelContainerOut
7-
from ..utils.database import inner_db, paginate
7+
from ..utils.database import inner_db
88
from ..utils.query import query_result_to_object
99

1010

@@ -15,7 +15,7 @@ def get_unassigned(limit: int, page: int):
1515
Container.parentId.is_(None),
1616
)
1717

18-
paged_result = paginate(query, limit, page, slow_count=False, scalar=False)
18+
paged_result = inner_db.paginate(query, limit, page, slow_count=False, scalar=False)
1919
paged_result.items = query_result_to_object(paged_result.items)
2020
return paged_result
2121

@@ -42,4 +42,4 @@ def get_internal_container_tree(top_level_container_id: int):
4242
def get_internal_containers(limit: int, page: int):
4343
query = select(TopLevelContainer).filter(TopLevelContainer.isInternal.is_(True))
4444

45-
return paginate(query, limit, page, slow_count=False, scalar=False)
45+
return inner_db.paginate(query, limit, page, slow_count=False, scalar=False)

src/scaup/crud/samples.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from ..models.samples import OptionalSample, SampleIn, SampleOut
1010
from ..utils.config import Config
1111
from ..utils.crud import assert_not_booked, edit_item
12-
from ..utils.database import inner_db, paginate
12+
from ..utils.database import inner_db
1313
from ..utils.external import ExternalRequest
1414
from ..utils.session import retry_if_exists
1515

@@ -140,7 +140,7 @@ def get_samples(
140140
query = query.filter(Container.isInternal.is_not(True))
141141

142142
query = query.order_by(Container.name, Container.location, Sample.location)
143-
samples = paginate(query, limit, page, slow_count=True, scalar=True)
143+
samples = inner_db.paginate(query, limit, page, slow_count=True, scalar=True)
144144

145145
if ignore_external or token is None:
146146
return samples

src/scaup/routes/internal.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from fastapi import APIRouter, Body, Depends, status
22
from fastapi.security import HTTPAuthorizationCredentials
3-
from lims_utils.models import pagination
3+
from lims_utils.models import Paged, pagination
44

55
from ..auth import User, auth_scheme
66
from ..crud import internal as crud
@@ -10,7 +10,6 @@
1010
from ..models.shipments import GenericItem, ShipmentChildren
1111
from ..models.top_level_containers import TopLevelContainerIn, TopLevelContainerOut
1212
from ..utils.auth import check_em_staff
13-
from ..utils.database import Paged
1413

1514

1615
def _internal_check_em_staff(user=Depends(User)):

src/scaup/routes/proposals.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from fastapi import APIRouter, Body, Depends, Query, status
44
from fastapi.security import HTTPAuthorizationCredentials
5-
from lims_utils.models import ProposalReference, pagination
5+
from lims_utils.models import Paged, ProposalReference, pagination
66

77
from ..auth import Permissions, auth_scheme
88
from ..crud import containers as containers_crud
@@ -11,7 +11,6 @@
1111
from ..models.containers import ContainerOut
1212
from ..models.samples import SampleOut, SublocationAssignment
1313
from ..models.shipments import ShipmentIn, ShipmentOut
14-
from ..utils.database import Paged
1514
from ..utils.external import ExternalRequest
1615

1716
auth = Permissions.session
@@ -32,7 +31,7 @@ def create_shipment(
3231
parameters: ShipmentIn = Body(),
3332
):
3433
"""Create new shipment in session"""
35-
return crud.create_shipment(proposalReference, params=parameters)
34+
return crud.create_shipment(proposal_reference=proposalReference, params=parameters)
3635

3736

3837
@router.get(

0 commit comments

Comments
 (0)