Add tests for devsta PV generation

Minor fix to builder

Author: OCopping

src/techui_builder/builder.py

@@ -126,7 +126,7 @@ def _create_devsta_pv(self, prefix: str, inputs: list[str]):
         self.devsta_pvs[prefix] = devsta_pv
 
     def write_devsta_pvs(self):
-        conf_dir = self._write_directory.parent.joinpath("config")
+        conf_dir = self._write_directory.joinpath("config")
 
         # Create the config/ dir if it doesn't exist
         if not conf_dir.exists():

tests/test_builder.py

@@ -1,11 +1,13 @@
 import logging
 import os
+from io import StringIO
 from pathlib import Path
-from unittest.mock import Mock, patch
+from unittest.mock import Mock, mock_open, patch
 
 import pytest
 from lxml import objectify
 from phoebusgen.widget import ActionButton, Group
+from softioc.builder import ClearRecords, records
 
 from techui_builder.builder import (
     JsonMap,
@@ -67,6 +69,80 @@ def test_component_attributes(
         assert component.extras == extras
 
 
+def test_builder_create_devsta_pv(builder):
+    p = "BL01T-MO-MOTOR-01"
+    inpa = "BL01T-MO-MOTOR-01:MOTOR1.MOVN"
+    builder._create_devsta_pv(prefix=p, inputs=[inpa])
+
+    devsta_pv = """
+record(calc, "BL01T-MO-MOTOR-01:DEVSTA")
+{
+    field(ACKT, "NO")
+    field(CALC, "(A|B|C|D|E|F|G|H|I|J|K|L)>0?1:0")
+    field(INPA, "BL01T-MO-MOTOR-01:MOTOR1.MOVN")
+    field(INPB, "")
+    field(INPC, "")
+    field(INPD, "")
+    field(INPE, "")
+    field(INPF, "")
+    field(INPG, "")
+    field(INPH, "")
+    field(INPI, "")
+    field(INPJ, "")
+    field(INPK, "")
+    field(INPL, "")
+    field(SCAN, "1 second")
+}
+"""
+
+    assert builder.devsta_pvs != {}
+
+    # Fake file-like object to "print" the record to
+    auto_devsta_pv = StringIO()
+    # Get the string representation of the record
+    builder.devsta_pvs[p].Print(auto_devsta_pv)
+
+    assert auto_devsta_pv.getvalue() == devsta_pv
+
+    # Make sure the record is deleted
+    ClearRecords()
+
+
+def test_builder_write_devsta_pvs(builder):
+    # To mock the open() function used in _write_devsta_pvs
+    m = mock_open()
+
+    p = "BL01T-MO-MOTOR-01"
+    inpa = "BL01T-MO-MOTOR-01:MOTOR1.MOVN"
+    devsta_pv = records.calc(  # pyright: ignore[reportAttributeAccessIssue]
+        f"{p}:DEVSTA",
+        CALC="(A|B|C|D|E|F|G|H|I|J|K|L)>0?1:0",
+        SCAN="1 second",
+        ACKT="NO",
+        INPA=inpa,
+    )
+    builder.devsta_pvs[p] = devsta_pv
+
+    # Mock the Print() function so we don't actually write a file
+    with (
+        patch("builtins.open", m),
+        patch("techui_builder.builder.Record.Print") as mock_print,
+    ):
+        builder.write_devsta_pvs()
+
+        # Check open() was called with the correct args
+        m.assert_called_once_with(
+            Path(
+                "/workspaces/techui-builder/tests/t01-services/synoptic/config/devsta.db"
+            ),
+            "w",
+        )
+        mock_print.assert_called_once()
+
+    # Make sure the record is deleted
+    ClearRecords()
+
+
 def test_missing_service(builder, caplog):
     builder._extract_entities = Mock(side_effect=OSError())
     builder._extract_services()
@@ -134,16 +210,22 @@ def test_builder_validate_screen(builder_with_setup):
 
 
 def test_create_screens(builder_with_setup):
+    # We don't want to make a devsta PV in this test
+    builder_with_setup._create_devsta_pv = Mock()
     # We don't want to access Generator in this test
     builder_with_setup._generate_screen = Mock()
     builder_with_setup._validate_screen = Mock()
+
     builder_with_setup.create_screens()
 
     builder_with_setup._generate_screen.assert_called()
     # builder_with_setup._validate_screen.assert_called()
 
 
 def test_create_screens_no_entities(builder, caplog):
+    # We don't want to make a devsta PV in this test
+    builder._create_devsta_pv = Mock()
+
     builder.entities = []
 
     # We only wan't to capture CRITICAL output in this test
@@ -156,6 +238,8 @@ def test_create_screens_no_entities(builder, caplog):
 
 
 def test_create_screens_extra_p_does_not_exist(builder_with_setup, caplog):
+    # We don't want to make a devsta PV in this test
+    builder_with_setup._create_devsta_pv = Mock()
     # We don't want to actually generate a screen
     builder_with_setup._generate_screen = Mock(side_effect=None)