mapDispatchToProps rule

Author: DianaSuvorova

README.md

@@ -43,4 +43,12 @@ Then configure the rules you want to use under the rules section.
 
 ## Supported Rules
 
-* [react-redux/connect-prefer-named-parameters](docs/rules/connect-prefer-named-parameters.md) Enforces that all connect parameters have specific names.
+'react-redux/connect-prefer-minimum-two-arguments': 0,
+'react-redux/connect-prefer-named-parameters': 2,
+'react-redux/mapStateToProps-prefer-parameters-names': 2,
+'react-redux/mapDispatchToProps-prefer-parameters-names': 2,
+
+* [react-redux/connect-prefer-minimum-two-arguments](docs/rules/connect-prefer-minimum-two-arguments.md) Enforces that connect function has at least 2 arguments.
+* [react-redux/connect-prefer-named-arguments](docs/rules/connect-prefer-named-arguments.md) Enforces that all connect arguments have specific names.
+* [react-redux/mapStateToProps-prefer-parameters-names](docs/rules/mapStateToProps-prefer-parameters-names.md) Enforces that all mapStateToProps parameters have specific names.
+* [react-redux/mapDispatchToProps-prefer-parameters-names](docs/rules/mapDispatchToProps-prefer-parameters-names.md) Enforces that all mapDispatchToProps parameters have specific names.

docs/rules/connect-prefer-minimum-two-arguments.md

@@ -0,0 +1,25 @@
+#  Enforces that connect function is provided with at least 2 arguments. (react-redux/connect-prefer-minimum-two-arguments)
+
+[react-redux mapStateToProps](https://github.com/reactjs/react-redux/blob/master/docs/api.md#connectmapstatetoprops-mapdispatchtoprops-mergeprops-options)
+
+> If you do not supply your own mapDispatchToProps function or object full of action creators, the default mapDispatchToProps implementation just injects dispatch into your component’s props.
+
+This rule enforces that Second argument is provided explicitly.
+
+## Rule details
+
+The following pattern is considered warnings:
+
+```js
+connect(mapStateToProps, null, mergeProps)(Component)
+```
+
+The following patterns are considered correct:
+
+```js
+connect(mapStateToProps, mapDispatchToProps, mergeProps)(Component)
+```
+
+```js
+connect(mapStateToProps, mapDispatchToProps)(Component)
+```

docs/rules/connect-prefer-named-parameters.md renamed to docs/rules/connect-prefer-named-arguments.md

@@ -1,4 +1,4 @@
-#  Enforces that all connect parameters have specific names. (react-redux/connect-prefer-named-parameters)
+#  Enforces that all connect arguments have specific names. (react-redux/connect-prefer-named-arguments)
 
 [react-redux connect](https://github.com/reactjs/react-redux/blob/master/docs/api.md#connectmapstatetoprops-mapdispatchtoprops-mergeprops-options) function has 4 optional arguments:
 * mapStateToProps

docs/rules/mapDispatchToProps-prefer-parameters-names.md

@@ -0,0 +1,29 @@
+#  Enforces that all mapDispatchToProps parameters have specific names. (react-redux/mapDispatchToProps-prefer-named-parameters)
+
+[react-redux mapStateToProps](https://github.com/reactjs/react-redux/blob/master/docs/api.md#connectmapstatetoprops-mapdispatchtoprops-mergeprops-options) function has 2 optional arguments:
+* state
+* ownProps
+
+This rule enforces that all of the provided parameters should follow the above naming conventions.
+
+## Rule details
+
+The following pattern is considered warnings:
+
+```js
+const mapDispatchToProps = (anyOtherName) => {}
+```
+
+The following patterns are considered correct:
+
+```js
+const mapDispatchToProps = () => {}
+```
+
+```js
+const mapDispatchToProps(dispatch, ownProps) => {}
+```
+
+```js
+const mapDispatchToProps(dispatch) => {}
+```

docs/rules/mapStateToProps-prefer-parameters-names.md

@@ -11,15 +11,15 @@ This rule enforces that all of the provided parameters should follow the above n
 The following pattern is considered warnings:
 
 ```js
-mapStateToProps(anyOtherName)
+const mapStateToProps = (anyOtherName) => {}
 ```
 
 The following patterns are considered correct:
 
 ```js
-mapStateToProps(state, ownProps)
+const mapStateToProps = (state, ownProps) => {}
 ```
 
 ```js
-mapStateToProps(state)
+const mapStateToProps = (state) => {}
 ```

index.js

@@ -1,14 +1,19 @@
 const rules = {
-  'connect-prefer-named-parameters': require('./lib/rules/connect-prefer-named-parameters'),
+  'connect-prefer-minimum-two-arguments': require('./lib/rules/connect-prefer-minimum-two-arguments'),
+  'connect-prefer-named-arguments': require('./lib/rules/connect-prefer-named-parameters'),
   'mapStateToProps-prefer-parameters-names': require('./lib/rules/mapStateToProps-prefer-parameters-names'),
+  'mapDispatchToProps-prefer-parameters-names': require('./lib/rules/mapDispatchToProps-prefer-parameters-names'),
+
 };
 
 module.exports = {
   rules,
   configs: {
     recommended: {
-      'react-redux/connect-prefer-named-parameters': 2,
+      'react-redux/connect-prefer-minimum-two-arguments': 0,
+      'react-redux/connect-prefer-named-arguments': 2,
       'react-redux/mapStateToProps-prefer-parameters-names': 2,
+      'react-redux/mapDispatchToProps-prefer-parameters-names': 2,
     },
     all: {
       rules,

lib/rules/connect-prefer-minimum-two-arguments.js

@@ -0,0 +1,20 @@
+const isReactReduxConnect = require('../isReactReduxConnect');
+
+const report = function (context, node) {
+  context.report({
+    message: 'Connect function should have 2 arguments',
+    node,
+  });
+};
+
+module.exports = function (context) {
+  return {
+    CallExpression(node) {
+      if (isReactReduxConnect(node)) {
+        if (node.arguments.length < 2) {
+          report(context, node);
+        }
+      }
+    },
+  };
+};

lib/rules/connect-prefer-named-parameters.js renamed to lib/rules/connect-prefer-named-arguments.js

@@ -9,7 +9,7 @@ const argumentNames = [
 
 const report = function (context, node, i) {
   context.report({
-    message: `Connect function parameter #${i} should be named ${argumentNames[i]}`,
+    message: `Connect function argument #${i} should be named ${argumentNames[i]}`,
     node,
   });
 };

lib/rules/mapDispatchToProps-prefer-parameters-names.js

@@ -0,0 +1,31 @@
+const argumentNames = [
+  'dispatch',
+  'ownProps',
+];
+
+const report = function (context, node, i) {
+  context.report({
+    message: `mapDispatchToProps function parameter #${i} should be named ${argumentNames[i]}`,
+    node,
+  });
+};
+
+const checkDeclaration = function (context, node) {
+  if (node.id && node.id.name === 'mapDispatchToProps'
+    && node.init && node.init.params
+  ) {
+    node.init.params.forEach((param, i) => {
+      if (argumentNames[i] && argumentNames[i] !== param.name) {
+        report(context, param, i);
+      }
+    });
+  }
+};
+
+module.exports = function (context) {
+  return {
+    VariableDeclaration(node) {
+      node.declarations.forEach(decl => checkDeclaration(context, decl));
+    },
+  };
+};

lib/rules/mapStateToProps-prefer-parameters-names.js

@@ -10,21 +10,22 @@ const report = function (context, node, i) {
   });
 };
 
+const checkDeclaration = function (context, node) {
+  if (node.id && node.id.name === 'mapStateToProps'
+    && node.init && node.init.params
+  ) {
+    node.init.params.forEach((param, i) => {
+      if (argumentNames[i] && argumentNames[i] !== param.name) {
+        report(context, param, i);
+      }
+    });
+  }
+};
+
 module.exports = function (context) {
   return {
-    CallExpression(node) {
-      if (node.callee.name === 'mapStateToProps') {
-        node.arguments.forEach((argument, i) => {
-          if (argument.raw && argument.raw !== 'null') {
-            report(context, node, i);
-          } else if (
-            !argument.raw
-            && argumentNames[i]
-            && (!argument.name || argument.name !== argumentNames[i])) {
-            report(context, node, i);
-          }
-        });
-      }
+    VariableDeclaration(node) {
+      node.declarations.forEach(decl => checkDeclaration(context, decl));
     },
   };
 };