connect-prefer-named-params: more cases and docs

Author: DianaSuvorova

.eslintrc.js

@@ -6,7 +6,8 @@ module.exports = {
         "import"
     ],
     rules: {
-      "func-names": 0
+      "func-names": 0,
+      "global-require": 0
     },
     "env": {
       mocha: true

README.md

@@ -36,11 +36,11 @@ Then configure the rules you want to use under the rules section.
 ```json
 {
     "rules": {
-        "react-redux/rule-name": 2
+        "react-redux/connect-prefer-named-parameters": 2
     }
 }
 ```
 
 ## Supported Rules
 
-* Fill in provided rules here
+* [react-redux/connect-prefer-named-parameters](docs/rules/connect-prefer-named-parameters.md) Enforces that all connect parameters have specific names.

docs/rules/connect-prefer-named-parameters.md

@@ -0,0 +1,31 @@
+#  Enforces that all connect parameters have specific names. (react-redux/connect-prefer-named-parameters)
+
+[react-redux connect](https://github.com/reactjs/react-redux/blob/master/docs/api.md#connectmapstatetoprops-mapdispatchtoprops-mergeprops-options) function has 4 optional arguments:
+* mapStateToProps
+* mapDispatchToProps
+* mergeProps
+* options
+
+This rule enforces that all of the provided parameters should follow the above naming conventions.
+
+## Rule details
+
+The following patterns are considered warnings:
+
+```js
+connect(mapStateToProps, actionCreators)(TodoApp)
+```
+
+```js
+connect(state => state)(TodoApp)
+```
+
+The following patterns are considered correct:
+
+```js
+connect(mapStateToProps, actionCreators, mergeProps)(TodoApp)
+```
+
+```js
+connect()(TodoApp)
+```

index.js

@@ -6,7 +6,7 @@ module.exports = {
   rules,
   configs: {
     recommended: {
-      rules,
+      'react-redux/connect-prefer-named-parameters': 2,
     },
     all: {
       rules,

lib/rules/connect-prefer-named-parameters.js

@@ -19,7 +19,9 @@ module.exports = function (context) {
     CallExpression(node) {
       if (isReactReduxConnect(node)) {
         node.arguments.forEach((argument, i) => {
-          if (!argument.name || argument.name !== argumentNames[i]) {
+          if (argument.raw && argument.raw !== 'null') {
+            report(context, node, i);
+          } else if (!argument.raw && (!argument.name || argument.name !== argumentNames[i])) {
             report(context, node, i);
           }
         });

npm-debug.log

@@ -15,8 +15,10 @@ const ruleTester = new RuleTester({ parserOptions });
 
 ruleTester.run('connect-prefer-named-parameters', rule, {
   valid: [
+    'connect(null, mapDispatchToProps)(TodoApp)',
     'connect(mapStateToProps, mapDispatchToProps, mergeProps, options)(Component)',
     'connect(mapStateToProps, mapDispatchToProps)(Component)',
+    'connect()(TodoApp)',
   ],
   invalid: [{
     code: 'connect(() => {}, () => {}, mergeProps, options)(Component)',
@@ -36,6 +38,12 @@ ruleTester.run('connect-prefer-named-parameters', rule, {
         message: 'Connect function parameter #1 should be named mapDispatchToProps',
       },
     ],
-  },
-  ],
+  }, {
+    code: 'connect(state => state)(TodoApp)',
+    errors: [
+      {
+        message: 'Connect function parameter #0 should be named mapStateToProps',
+      },
+    ],
+  }],
 });