-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Open
Description
The TODO comment below that can be found in the LogCommand method deals with the case when WAL entry exceeds the pre-allocated buffer size.
Expected behaviour in this case would be to create a temporary buffer of required size and use that instead of exitsing buffer. Put a check for extremely large sized buffer writes that cross the threshold of a single buffer and return an error. Please keep the threshold value as a enum so that it is easy to refer and change in future.
// TOCO: In this case, we can do a one time creation of a new buffer
// and proceed rather than using the existing buffer.
Setup Instructions
- setup DiceDB server locally from the source - instructions
- setup DiceDB Go SDK locally from the source - instructions
- setup DiceDB CLI locally from the source - instructions
- refer to the
Pointing to local checked-outdicedb-gosection inREADME`.
Start the DiceDB server
$ go run main.go --log-level debug
Follow the contribution guidelines
These are general guidelines to follow before you submit a patch. Please mark them as done once you complete them
- please go through the CONTRIBUTING guide
- follow LOGGING best practices
- follow Golang best practices
- run
make linton your local copy of the codebase
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels