Skip to content

Commit df0ee64

Browse files
authored
Merge pull request #21 from Didstopia/development
Preparing for a new release
2 parents ee30100 + d21b088 commit df0ee64

File tree

5 files changed

+16
-11
lines changed

5 files changed

+16
-11
lines changed

Didstopia.PDFSharp.Tests/Didstopia.PDFSharp.Tests.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFramework>netcoreapp2.0</TargetFramework>
5-
<ReleaseVersion>1.0.0-beta5</ReleaseVersion>
5+
<ReleaseVersion>1.0.0-beta6</ReleaseVersion>
66
<Description>A .NET Standard 2.0 library for reading, writing and editing PDF files.
77

88
This is a modified fork based on several OSS projects. For more information see the license.</Description>
@@ -19,7 +19,7 @@ This is a modified fork based on several OSS projects. For more information see
1919
<PackageReference Include="SixLabors.ImageSharp" Version="1.0.0-beta0002" />
2020
<PackageReference Include="xunit" Version="2.3.1" />
2121
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
22-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.6.0" />
22+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.6.1" />
2323
</ItemGroup>
2424

2525
<ItemGroup>

Didstopia.PDFSharp.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,6 @@ Global
7676
EndGlobalSection
7777
GlobalSection(MonoDevelopProperties) = preSolution
7878
description = @A .NET Standard 2.0 library for reading, writing and editing PDF files.\r\n\r\nThis is a modified fork based on several OSS projects. For more information see the license.
79-
version = 1.0.0-beta5
79+
version = 1.0.0-beta6
8080
EndGlobalSection
8181
EndGlobal

Didstopia.PDFSharp/Didstopia.PDFSharp.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFramework>netstandard2.0</TargetFramework>
5-
<ReleaseVersion>1.0.0-beta5</ReleaseVersion>
5+
<ReleaseVersion>1.0.0-beta6</ReleaseVersion>
66
<VersionPrefix>0.0.1</VersionPrefix>
77
<VersionSuffix></VersionSuffix>
88
<Authors>Didstopia, ststeiger, roceh, empira</Authors>

Didstopia.PDFSharp/Drawing/XImage.cs

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -176,17 +176,22 @@ public static XImage FromImageSource(IImageSource imageSouce)
176176
/// <param name="path">The path to a BMP, PNG, GIF, JPEG, TIFF, or PDF file.</param>
177177
public static bool ExistsFile(string path)
178178
{
179-
// Support for "base64:" pseudo protocol is a MigraDoc feature, currently completely implemented in MigraDoc files. TODO: Does support for "base64:" make sense for PDFsharp? Probably not as PDFsharp can handle images from streams.
180-
//if (path.StartsWith("base64:")) // The Image is stored in the string here, so the file exists.
181-
// return true;
182-
183-
if (PdfReader.TestPdfFile(path) > 0)
179+
// Support for "base64:" pseudo protocol is a MigraDoc feature, currently completely implemented in MigraDoc files. TODO: Does support for "base64:" make sense for PDFsharp? Probably not as PDFsharp can handle images from streams.
180+
//if (path.StartsWith("base64:")) // The Image is stored in the string here, so the file exists.
181+
// return true;
182+
183+
// NOTE: The old method below would try to validate the PDF file,
184+
// which has nothing to do with checking for the existence of a file
185+
return File.Exists(path);
186+
187+
/*if (PdfReader.TestPdfFile(path) > 0)
184188
return true;
189+
185190
#if !NETFX_CORE && !UWP && !PORTABLE
186191
return File.Exists(path);
187192
#else
188193
return false;
189-
#endif
194+
#endif*/
190195
}
191196

192197
internal XImageState XImageState

Didstopia.PDFSharp/Drawing/XPdfForm.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ internal XPdfForm(Stream stream)
9696
/// <summary>
9797
/// Creates an XPdfForm from a file.
9898
/// </summary>
99-
public static new XPdfForm FromFile(string path)
99+
public static XPdfForm FromFile(string path)
100100
{
101101
// TODO: Same file should return same object (that's why the function is static).
102102
return new XPdfForm(path);

0 commit comments

Comments
 (0)