test: excludeGraphQLFetch should default to not assuming GraphQL when missing the URL

Author: spawnia

src/excludeGraphQLFetch.ts

@@ -14,9 +14,9 @@ export const excludeGraphQLFetch: BeforeBreadcrumbCallback = (breadcrumb) => {
   return breadcrumb;
 };
 
-export const withoutGraphQLFetch = (
-  beforeBreadcrumb: BeforeBreadcrumbCallback
-): BeforeBreadcrumbCallback => {
+export function withoutGraphQLFetch(
+  beforeBreadcrumb: BeforeBreadcrumbCallback,
+): BeforeBreadcrumbCallback {
   return (breadcrumb, hint) => {
     const withoutFetch = excludeGraphQLFetch(breadcrumb, hint);
     if (withoutFetch === null) {
@@ -25,4 +25,4 @@ export const withoutGraphQLFetch = (
 
     return beforeBreadcrumb(withoutFetch, hint);
   };
-};
+}

tests/excludeGraphQLFetch.test.ts

@@ -6,21 +6,30 @@ describe('excludeGraphQLFetch', () => {
       excludeGraphQLFetch({
         category: 'fetch',
         data: { url: 'https://example.com/graphql' },
-      })
+      }),
     ).toBeNull();
   });
 
+  it('should default to not assuming GraphQL when missing the URL', () => {
+    const breadcrumb = {
+      category: 'fetch',
+      data: {},
+    };
+
+    expect(excludeGraphQLFetch(breadcrumb)).toBe(breadcrumb);
+  });
+
   it('should leave non-GraphQL fetches', () => {
     const breadcrumb = {
       category: 'fetch',
       data: { url: 'https://example.com' },
     };
-    expect(excludeGraphQLFetch(breadcrumb)).toEqual(breadcrumb);
+    expect(excludeGraphQLFetch(breadcrumb)).toBe(breadcrumb);
   });
 
   it('should leave non-fetch breadcrumbs', () => {
     const breadcrumb = { category: 'not-fetch' };
-    expect(excludeGraphQLFetch(breadcrumb)).toEqual(breadcrumb);
+    expect(excludeGraphQLFetch(breadcrumb)).toBe(breadcrumb);
   });
 });
 
@@ -34,7 +43,7 @@ describe('withoutGraphQLFetch', () => {
       wrapped({
         category: 'fetch',
         data: { url: 'https://example.com/graphql' },
-      })
+      }),
     ).toBeNull();
     expect(callback).not.toHaveBeenCalled();
   });
@@ -49,7 +58,7 @@ describe('withoutGraphQLFetch', () => {
 
     const wrapped = withoutGraphQLFetch(callback);
 
-    expect(wrapped(initial, hint)).toEqual(altered);
+    expect(wrapped(initial, hint)).toBe(altered);
     expect(callback).toHaveBeenCalledTimes(1);
     expect(callback).toHaveBeenCalledWith(initial, hint);
   });