Skip to content

Commit 74d9575

Browse files
committed
Add UPGRADE.md
1 parent 4d7f0e5 commit 74d9575

File tree

5 files changed

+42
-6
lines changed

5 files changed

+42
-6
lines changed

UPGRADE.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
# Upgrade guide
2+
3+
This document provides guidance for upgrading between major versions of `apollo-link-sentry`.
4+
5+
## v2 to v3
6+
7+
### Adapt your configuration
8+
9+
The configuration of `SentryLink` has changed.
10+
11+
```diff
12+
import { SentryLink } from 'apollo-link-sentry';
13+
14+
new SentryLink({
15+
- filter: (operation) => ...,
16+
+ shouldHandleOperation: (operation) => ...,
17+
+ uri: 'https://example.com/graphql',
18+
setTransaction: true,
19+
setFingerprint: true,
20+
21+
- breadcrumb: {
22+
- enable: true,
23+
+ attachBreadcrumbs: {
24+
includeQuery: false,
25+
includeVariables: false,
26+
- includeFetchResult: false,
27+
+ includeFetchResult: false,
28+
includeError: false,
29+
includeCache: false,
30+
- includeContext: ['example'],
31+
+ includeContext: ['example'],
32+
+ transform: (breadcrumb, operation) => ...,
33+
},
34+
- beforeBreadcrumb: (breadcrumb) => ...,
35+
})
36+
```

src/SentryLink.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export class SentryLink extends ApolloLink {
5757
// We must have a breadcrumb if attachBreadcrumbs was set
5858
(breadcrumb as GraphQLBreadcrumb).level = severityForResult(result);
5959

60-
if (this.options.attachBreadcrumbs.includeResult) {
60+
if (this.options.attachBreadcrumbs.includeFetchResult) {
6161
// We must have a breadcrumb if attachBreadcrumbs was set
6262
(breadcrumb as GraphQLBreadcrumb).data.fetchResult = result;
6363
}

src/options.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export type AttachBreadcrumbsOptions = {
6868
*
6969
* Be careful not to leak sensitive information or send too much data.
7070
*/
71-
includeResult: false | true;
71+
includeFetchResult: false | true;
7272

7373
/**
7474
* Include the response error?
@@ -113,7 +113,7 @@ export const defaultOptions = {
113113
attachBreadcrumbs: {
114114
includeQuery: false,
115115
includeVariables: false,
116-
includeResult: false,
116+
includeFetchResult: false,
117117
includeError: false,
118118
includeCache: false,
119119
includeContext: false,

tests/apolloSentryLink.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ describe('SentryLink', () => {
5959

6060
it('should attach a breadcrumb for each apolloOperation', (done) => {
6161
const includeErrorAndResultOptions: SentryLinkOptions = {
62-
attachBreadcrumbs: { includeResult: true, includeError: true },
62+
attachBreadcrumbs: { includeFetchResult: true, includeError: true },
6363
};
6464

6565
const result = { data: { foo: true } };

tests/breadcrumb.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('makeBreadcrumb', () => {
3232
includeQuery: false,
3333
includeVariables: false,
3434
includeError: false,
35-
includeResult: false,
35+
includeFetchResult: false,
3636
includeCache: false,
3737
includeContext: false,
3838
transform: undefined,
@@ -84,7 +84,7 @@ describe('makeBreadcrumb', () => {
8484
includeQuery: true,
8585
includeVariables: true,
8686
includeError: true,
87-
includeResult: true,
87+
includeFetchResult: true,
8888
includeCache: true,
8989
includeContext: ['foo.bar'],
9090
transform: (breadcrumb) => breadcrumb,

0 commit comments

Comments
 (0)