Refactor global currency and creation of exchange api

Exchange API now uses private constructor, and provides methods to get an exchange by type rather than by name.

Author: jjxtra

CONTRIBUTING.md

@@ -26,6 +26,8 @@ When creating a new Exchange API, please do the following:
 - Ensure that the unit tests and integrations tests (```ExchangeSharpConsole.exe test exchangeName=[name]```) pass before submitting a pull request.
 - Set needed properties in the constructor of the exchange, such as NonceStyle, NonceEndPoint, NonceEndPointField, NonceEndPointStyle and any property in /API/Exchanges/_Base/ExchangeAPIDefinitions.cs.
 - If you have very custom nonce offset calculation logic, you can override OnGetNonceOffset, but please do only if absolutely necessary.
+- Exchange implementation classes should be sealed and have a private constructor.
+- One-time exchange initialization can be performed by overring `OnInitializeAsync()`.
 
 
 

src/ExchangeSharp/API/Exchanges/Aquanow/ExchangeAquanowAPI.cs

@@ -26,7 +26,7 @@ public sealed partial class ExchangeAquanowAPI : ExchangeAPI
         public string MarketUrl { get; set; } = "https://market.aquanow.io";
         public override string BaseUrlWebSocket { get; set; } = "wss://market.aquanow.io/";
 
-        public ExchangeAquanowAPI()
+		private ExchangeAquanowAPI()
         {
             NonceStyle = NonceStyle.UnixMilliseconds;
             RequestContentType = "application/x-www-form-urlencoded";

src/ExchangeSharp/API/Exchanges/BL3P/ExchangeBL3PAPI.cs

@@ -31,7 +31,7 @@ public sealed class ExchangeBL3PAPI : ExchangeAPI
 		/// </summary>
 		public BL3PCurrencyFee DefaultFeeCurrency { get; set; } = BL3PCurrencyFee.BTC;
 
-		public ExchangeBL3PAPI()
+		private ExchangeBL3PAPI()
 		{
 			MarketSymbolIsUppercase = true;
 			MarketSymbolIsReversed = true;

src/ExchangeSharp/API/Exchanges/BTSE/ExchangeBTSEAPI.cs

@@ -13,7 +13,7 @@ public sealed partial class ExchangeBTSEAPI : ExchangeAPI
 		public override string BaseUrl { get; set; } = "https://api.btse.com/spot";
 		public const string TestnetUrl = "https://testapi.btse.io/spot";
 
-		public ExchangeBTSEAPI()
+		private ExchangeBTSEAPI()
 		{
 			NonceStyle = NonceStyle.UnixMillisecondsString;
 		}

src/ExchangeSharp/API/Exchanges/BinanceGroup/BinanceGroupCommon.cs

@@ -31,14 +31,6 @@ public abstract class BinanceGroupCommon : ExchangeAPI
 
 		public const string GetCurrenciesUrl = "/assetWithdraw/getAllAsset.html";
 
-		static BinanceGroupCommon()
-		{
-			ExchangeGlobalCurrencyReplacements[typeof(BinanceGroupCommon)] = new KeyValuePair<string, string>[]
-			{
-				new KeyValuePair<string, string>("BCC", "BCH")
-			};
-		}
-
 		protected async Task<string> GetWebSocketStreamUrlForSymbolsAsync(string suffix, params string[] marketSymbols)
 		{
 			if (marketSymbols == null || marketSymbols.Length == 0)
@@ -67,6 +59,7 @@ protected BinanceGroupCommon()
 			NonceOffset = TimeSpan.FromSeconds(15); // 15 seconds are deducted from current UTCTime as base of the request time window
 			MarketSymbolSeparator = string.Empty;
 			WebSocketOrderBookType = WebSocketOrderBookType.DeltasOnly;
+			ExchangeGlobalCurrencyReplacements["BCC"] = "BCH";
 		}
 
 		public override Task<string> ExchangeMarketSymbolToGlobalMarketSymbolAsync(string marketSymbol)

src/ExchangeSharp/API/Exchanges/BitBank/ExchangeBitBankAPI.cs

@@ -18,22 +18,15 @@ public sealed partial class ExchangeBitBankAPI : ExchangeAPI
         private const decimal MakerFee = -0.0005m;
         private const decimal TakerFee = 0.0015m;
 
-        static ExchangeBitBankAPI()
-        {
-            ExchangeGlobalCurrencyReplacements[typeof(ExchangeBitBankAPI)] = new KeyValuePair<string, string>[]
-            {
-                new KeyValuePair<string, string>("BCC", "BCH")
-            };
-        }
-
-        public ExchangeBitBankAPI()
+		private ExchangeBitBankAPI()
         {
             NonceStyle = NonceStyle.UnixMilliseconds;
             NonceOffset = TimeSpan.FromSeconds(0.1);
             WebSocketOrderBookType = WebSocketOrderBookType.DeltasOnly;
             MarketSymbolSeparator = "_";
             MarketSymbolIsUppercase = false;
-        }
+			ExchangeGlobalCurrencyReplacements["BCC"] = "BCH";
+		}
 
         # region Public APIs
 

src/ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs

@@ -1,4 +1,4 @@
-/*
+/*
 MIT LICENSE
 
 Copyright 2017 Digital Ruby, LLC - http://www.digitalruby.com
@@ -33,7 +33,7 @@ public sealed partial class ExchangeBitMEXAPI : ExchangeAPI
         private SortedDictionary<long, decimal> dict_long_decimal = new SortedDictionary<long, decimal>();
         private SortedDictionary<decimal, long> dict_decimal_long = new SortedDictionary<decimal, long>();
 
-        public ExchangeBitMEXAPI()
+		private ExchangeBitMEXAPI()
         {
             RequestWindow = TimeSpan.Zero;
             NonceStyle = NonceStyle.ExpiresUnixSeconds;

src/ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs

@@ -24,15 +24,16 @@ namespace ExchangeSharp {
 	using System.Text.RegularExpressions;
 	using System.Threading.Tasks;
 
-	public sealed partial class ExchangeBitfinexAPI :ExchangeAPI {
+	public sealed partial class ExchangeBitfinexAPI :ExchangeAPI
+	{
 		public override string BaseUrl { get; set; } = "https://api.bitfinex.com/v2";
 		public override string BaseUrlWebSocket { get; set; } = "wss://api.bitfinex.com/ws";
 
 		public Dictionary<string, string> DepositMethodLookup { get; }
 
 		public string BaseUrlV1 { get; set; } = "https://api.bitfinex.com/v1";
 
-		public ExchangeBitfinexAPI()
+		private ExchangeBitfinexAPI()
 		{
 			NonceStyle = NonceStyle.UnixMillisecondsString;
 			RateLimit = new RateGate(1, TimeSpan.FromSeconds(6.0));

src/ExchangeSharp/API/Exchanges/Bithumb/ExchangeBithumbAPI.cs

@@ -22,7 +22,7 @@ public sealed partial class ExchangeBithumbAPI : ExchangeAPI
     {
         public override string BaseUrl { get; set; } = "https://api.bithumb.com";
 
-        public ExchangeBithumbAPI()
+		private ExchangeBithumbAPI()
         {
             MarketSymbolIsUppercase = true;
         }

src/ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs

@@ -35,11 +35,11 @@ public string CustomerId
             set { Passphrase = value.ToSecureString(); }
         }
 
-        /// <summary>
-        /// In order to use private functions of the API, you must set CustomerId by calling constructor with parameter,
-        /// or setting it later in the ExchangeBitstampAPI object.
-        /// </summary>
-        public ExchangeBitstampAPI()
+		/// <summary>
+		/// In order to use private functions of the API, you must set CustomerId by calling constructor with parameter,
+		/// or setting it later in the ExchangeBitstampAPI object.
+		/// </summary>
+		private ExchangeBitstampAPI()
         {
             RequestContentType = "application/x-www-form-urlencoded";
             NonceStyle = NonceStyle.UnixMilliseconds;