Simplify exception handling

Author: jjxtra

ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs

@@ -447,20 +447,13 @@ public virtual string CurrenciesToExchangeMarketSymbol(string baseCurrency, stri
             // no separator logic...
             if (string.IsNullOrWhiteSpace(MarketSymbolSeparator))
             {
-                try
-                {
-                    // we must look it up via metadata, most often this call will be cached and fast
-                    ExchangeMarket marketSymbolMetadata = await GetExchangeMarketFromCacheAsync(marketSymbol);
-                    if (marketSymbolMetadata == null)
-                    {
-                        throw new InvalidDataException($"No market symbol metadata returned or unable to find symbol metadata for {marketSymbol}");
-                    }
-                    return (marketSymbolMetadata.BaseCurrency, marketSymbolMetadata.QuoteCurrency);
-                }
-                catch (Exception e)
+                // we must look it up via metadata, most often this call will be cached and fast
+                ExchangeMarket marketSymbolMetadata = await GetExchangeMarketFromCacheAsync(marketSymbol);
+                if (marketSymbolMetadata == null)
                 {
-                    throw new InvalidOperationException($"Failed to retrieve symbol metadata for exchange {Name}.", e);
+                    throw new InvalidDataException($"No market symbol metadata returned or unable to find symbol metadata for {marketSymbol}");
                 }
+                return (marketSymbolMetadata.BaseCurrency, marketSymbolMetadata.QuoteCurrency);
             }
 
             // default behavior with separator

ExchangeSharpConsole/ExchangeSharpConsole_Main.cs

@@ -56,10 +56,6 @@ private static Dictionary<string, string> ParseCommandLine(string[] args)
             return dict;
         }
 
-        private static void TestMethod()
-        {
-        }
-
         /// <summary>
         /// Console app main method
         /// </summary>
@@ -81,7 +77,6 @@ public static async Task<int> ConsoleMain(string[] args)
             {
                 // swap out to external web socket implementation for older Windows pre 8.1
                 // ExchangeSharp.ClientWebSocket.RegisterWebSocketCreator(() => new ExchangeSharpConsole.WebSocket4NetClientWebSocket());
-                // TestMethod(); return 0; // uncomment for ad-hoc code testing
                 Logger.Info("ExchangeSharp console started.");
                 Dictionary<string, string> argsDictionary = ParseCommandLine(args);
                 if (argsDictionary.Count == 0 || argsDictionary.ContainsKey("help"))