Use AltMarketSymbol to hanlde Kraken WebSocket symbol difference and Gemini lower case symbol names. Pass isWebsocket flag in console app. (#594)

Author: EcBen

src/ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs

@@ -175,6 +175,7 @@ protected internal override async Task<IEnumerable<ExchangeMarket>> OnGetMarketS
 					}
 					decimal incrementSize = incrementNode.InnerText.Substring(0, incrementSizePos).ConvertInvariant<decimal>();
 					market.MarketSymbol = symbol;
+					market.AltMarketSymbol = symbol.ToUpper();
 					market.BaseCurrency = symbol.Substring(0, symbol.Length - 3);
 					market.QuoteCurrency = symbol.Substring(symbol.Length - 3);
 					market.MinTradeSize = minOrderSize;
@@ -412,7 +413,7 @@ static void PublishTicker(ExchangeTicker ticker, string marketSymbol, Concurrent
 							if (changesToken != null)
 							{
 								string marketSymbol = token["symbol"].ToStringInvariant();
-								if (changesToken.FirstOrDefault()is JArray candleArray)
+								if (changesToken.FirstOrDefault() is JArray candleArray)
 								{
 									decimal volume = candleArray[5].ConvertInvariant<decimal>();
 									volumeDict[marketSymbol] = volume;

src/ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs

@@ -410,6 +410,8 @@ protected override async Task<IEnumerable<string>> OnGetMarketSymbolsAsync(bool
 					.ToList();
 			}
 
+			names.Sort();
+
 			return names;
 		}
 

src/ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs

@@ -679,18 +679,32 @@ public virtual async Task<IEnumerable<ExchangeMarket>> GetMarketSymbolsMetadataA
 				// not sure if this is needed, but adding it just in case
 				await new SynchronizationContextRemover();
 				Dictionary<string, ExchangeMarket> lookup = await this.GetExchangeMarketDictionaryFromCacheAsync();
-				if (lookup != null && lookup.TryGetValue(marketSymbol, out ExchangeMarket market))
+
+				foreach(KeyValuePair<string, ExchangeMarket> kvp in lookup)
 				{
-					return market;
+					if ((kvp.Key == marketSymbol)
+						|| (kvp.Value.MarketSymbol == marketSymbol)
+						|| (kvp.Value.AltMarketSymbol == marketSymbol)
+						|| (kvp.Value.AltMarketSymbol2 == marketSymbol))
+					{
+						return kvp.Value;
+					}
 				}
 
 				// try again with a fresh request
 				Cache.Remove(nameof(GetMarketSymbolsMetadataAsync));
 				Cache.Remove(nameof(ExchangeAPIExtensions.GetExchangeMarketDictionaryFromCacheAsync));
 				lookup = await this.GetExchangeMarketDictionaryFromCacheAsync();
-				if (lookup != null && lookup.TryGetValue(marketSymbol, out market))
+
+				foreach (KeyValuePair<string, ExchangeMarket> kvp in lookup)
 				{
-					return market;
+					if ((kvp.Key == marketSymbol)
+						|| (kvp.Value.MarketSymbol == marketSymbol)
+						|| (kvp.Value.AltMarketSymbol == marketSymbol)
+						|| (kvp.Value.AltMarketSymbol2 == marketSymbol))
+					{
+						return kvp.Value;
+					}
 				}
 			}
 			catch

src/ExchangeSharpConsole/Options/WebSocketsTickersOption.cs

@@ -17,7 +17,7 @@ public override async Task RunCommand()
 		{
 			async Task<IWebSocket> GetWebSocket(IExchangeAPI api)
 			{
-				var symbols = await ValidateMarketSymbolsAsync(api, MarketSymbols.ToArray());
+				var symbols = await ValidateMarketSymbolsAsync(api, MarketSymbols.ToArray(), true);
 
 				return await api.GetTickersWebSocketAsync(freshTickers =>
 					{

src/ExchangeSharpConsole/Options/WebSocketsTradesOption.cs

@@ -17,7 +17,7 @@ public override async Task RunCommand()
 		{
 			async Task<IWebSocket> GetWebSocket(IExchangeAPI api)
 			{
-				var symbols = await ValidateMarketSymbolsAsync(api, MarketSymbols.ToArray());
+				var symbols = await ValidateMarketSymbolsAsync(api, MarketSymbols.ToArray(), true);
 
 				return await api.GetTradesWebSocketAsync(message =>
 					{