ConvertUBOToPushConstantPass: return SuccessWithoutChange if UBO is not found

Author: TheMostDiligent

Graphics/ShaderTools/src/ConvertUBOToPushConstant.cpp

@@ -93,7 +93,7 @@ class ConvertUBOToPushConstantPass : public spvtools::opt::Pass
         if (candidate_ids.empty())
         {
             // Block name not found
-            return Status::Failure;
+            return Status::SuccessWithoutChange;
         }
 
         // Try each candidate ID to find a UniformBuffer
@@ -188,7 +188,7 @@ class ConvertUBOToPushConstantPass : public spvtools::opt::Pass
         if (target_var == nullptr)
         {
             // No UniformBuffer found with the given block name
-            return Status::Failure;
+            return Status::SuccessWithoutChange;
         }
 
         uint32_t target_var_id = target_var->result_id();

Tests/DiligentCoreTest/src/ShaderTools/SPIRVShaderResourcesTest.cpp

@@ -345,8 +345,8 @@ void TestConvertUBOToPushConstant_InvalidBlockName(SHADER_COMPILER Compiler)
     if (::testing::Test::IsSkipped())
         return;
 
-    SPIRV = ConvertUBOToPushConstants(SPIRV, PatchedAttribName);
-    EXPECT_TRUE(SPIRV.empty());
+    std::vector<unsigned int> PatchedSPIRV = ConvertUBOToPushConstants(SPIRV, PatchedAttribName);
+    EXPECT_EQ(SPIRV, PatchedSPIRV);
 }
 
 TEST_F(SPIRVShaderResourcesTest, ConvertUBOToPushConstant_InvalidBlockName_GLSLang)
@@ -369,8 +369,8 @@ void TestConvertUBOToPushConstant_InvalidResourceType(SHADER_COMPILER Compiler)
     if (::testing::Test::IsSkipped())
         return;
 
-    SPIRV = ConvertUBOToPushConstants(SPIRV, PatchedAttribName);
-    EXPECT_TRUE(SPIRV.empty());
+    std::vector<unsigned int> PatchedSPIRV = ConvertUBOToPushConstants(SPIRV, PatchedAttribName);
+    EXPECT_EQ(SPIRV, PatchedSPIRV);
 }
 
 TEST_F(SPIRVShaderResourcesTest, ConvertUBOToPushConstant_InvalidResourceType_GLSLang)