Add validation for SHADER_VARIABLE_FLAG_INLINE_CONSTANTS flag

TheMostDiligent · TheMostDiligent · commit 20e4e94cf4ca · 2025-12-15T23:50:04.000-08:00
diff --git a/Graphics/GraphicsEngine/src/PipelineStateBase.cpp b/Graphics/GraphicsEngine/src/PipelineStateBase.cpp
@@ -478,6 +478,9 @@ void ValidatePipelineResourceLayoutDesc(const PipelineStateDesc& PSODesc, const
             if (Var.ShaderStages == SHADER_TYPE_UNKNOWN)
                 LOG_PSO_ERROR_AND_THROW("ResourceLayout.Variables[", i, "].ShaderStages must not be SHADER_TYPE_UNKNOWN.");
 
+            if ((Var.Flags & SHADER_VARIABLE_FLAG_INLINE_CONSTANTS) != 0 && (Var.Flags != SHADER_VARIABLE_FLAG_INLINE_CONSTANTS))
+                LOG_PSO_ERROR_AND_THROW("ResourceLayout.Variables[", i, "].Flags: INLINE_CONSTANTS flag cannot be combined with other flags.");
+
             auto range = UniqueVariables.equal_range(Var.Name);
             for (auto it = range.first; it != range.second; ++it)
             {

Original file line number	Diff line number	Diff line change
`@@ -478,6 +478,9 @@ void ValidatePipelineResourceLayoutDesc(const PipelineStateDesc& PSODesc, const`
`478`	`478`	`if (Var.ShaderStages == SHADER_TYPE_UNKNOWN)`
`479`	`479`	`LOG_PSO_ERROR_AND_THROW("ResourceLayout.Variables[", i, "].ShaderStages must not be SHADER_TYPE_UNKNOWN.");`
`480`	`480`
	`481`	`+ if ((Var.Flags & SHADER_VARIABLE_FLAG_INLINE_CONSTANTS) != 0 && (Var.Flags != SHADER_VARIABLE_FLAG_INLINE_CONSTANTS))`
	`482`	`+ LOG_PSO_ERROR_AND_THROW("ResourceLayout.Variables[", i, "].Flags: INLINE_CONSTANTS flag cannot be combined with other flags.");`
	`483`	`+`
`481`	`484`	`auto range = UniqueVariables.equal_range(Var.Name);`
`482`	`485`	`for (auto it = range.first; it != range.second; ++it)`
`483`	`486`	`{`