Fixed D3D12 warnings in unit tests (fix #669)

Author: TheMostDiligent

Graphics/HLSL2GLSLConverterLib/src/HLSL2GLSLConverterImpl.cpp

@@ -260,7 +260,6 @@
 // [V] modf( {float, float2, float3, float4} )
 //   (-) modf( {int, int2, int3, int4, matrix types} )
 // [V] mul - defined as a*b
-// [V] noise( {float, float2, float3, float4} )
 // [V] normalize( {float, float2, float3, float4} )
 // [V] pow( {float, float2, float3, float4} )
 //   (-) pow( {matrix types} )

Tests/DiligentCoreAPITest/src/ArchiveTest.cpp

@@ -2697,6 +2697,8 @@ TEST(ArchiveTest, MergeArchives)
         GraphicsPipeline.InputLayout.LayoutElements = Elems;
         GraphicsPipeline.InputLayout.NumElements    = _countof(Elems);
 
+        GraphicsPipeline.DepthStencilDesc.DepthEnable = False;
+
         PipelineStateArchiveInfo ArchiveInfo;
         ArchiveInfo.DeviceFlags = GetDeviceBits();
 

Tests/DiligentCoreAPITest/src/AsyncShaderCompilationTest.cpp

@@ -1,5 +1,5 @@
 /*
- *  Copyright 2024 Diligent Graphics LLC
+ *  Copyright 2024-2025 Diligent Graphics LLC
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
@@ -52,8 +52,8 @@ RefCntAutoPtr<IShader> CreateShader(const char*          Path,
     std::unique_ptr<ShaderCreateInfo> pShaderCI = std::make_unique<ShaderCreateInfo>();
     ShaderCreateInfo&                 ShaderCI  = *pShaderCI;
 
-    auto* pEnv    = GPUTestingEnvironment::GetInstance();
-    auto* pDevice = pEnv->GetDevice();
+    GPUTestingEnvironment* pEnv    = GPUTestingEnvironment::GetInstance();
+    IRenderDevice*         pDevice = pEnv->GetDevice();
 
     RefCntAutoPtr<IShaderSourceInputStreamFactory> pShaderSourceFactory;
     pDevice->GetEngineFactory()->CreateDefaultShaderSourceStreamFactory("shaders", &pShaderSourceFactory);
@@ -92,7 +92,7 @@ TEST(Shader, AsyncCompilation)
 {
     GPUTestingEnvironment::ScopedReset EnvironmentAutoReset;
 
-    const auto& DeviceInfo = GPUTestingEnvironment::GetInstance()->GetDevice()->GetDeviceInfo();
+    const RenderDeviceInfo& DeviceInfo = GPUTestingEnvironment::GetInstance()->GetDevice()->GetDeviceInfo();
     if (!DeviceInfo.Features.AsyncShaderCompilation)
     {
         GTEST_SKIP() << "Async shader compilation is not supported by this device";
@@ -101,18 +101,18 @@ TEST(Shader, AsyncCompilation)
     std::vector<RefCntAutoPtr<IShader>> Shaders;
     for (Uint32 i = 0; i < 10; ++i)
     {
-        auto pShader = CreateShader("AsyncShaderCompilationTest.psh", "Async compilation test", SHADER_TYPE_PIXEL, SHADER_COMPILE_FLAG_ASYNCHRONOUS);
+        RefCntAutoPtr<IShader> pShader = CreateShader("AsyncShaderCompilationTest.psh", "Async compilation test", SHADER_TYPE_PIXEL, SHADER_COMPILE_FLAG_ASYNCHRONOUS);
         ASSERT_NE(pShader, nullptr);
         Shaders.emplace_back(std::move(pShader));
     }
 
     Timer  T;
-    auto   StartTime = T.GetElapsedTime();
+    double StartTime = T.GetElapsedTime();
     Uint32 Iter      = 0;
     while (true)
     {
         Uint32 NumShadersReady = 0;
-        for (auto& pShader : Shaders)
+        for (RefCntAutoPtr<IShader>& pShader : Shaders)
         {
             if (pShader->GetStatus() == SHADER_STATUS_READY)
                 ++NumShadersReady;
@@ -130,13 +130,13 @@ TEST(Shader, ReleaseWhileCompiling)
 {
     GPUTestingEnvironment::ScopedReset EnvironmentAutoReset;
 
-    const auto& DeviceInfo = GPUTestingEnvironment::GetInstance()->GetDevice()->GetDeviceInfo();
+    const RenderDeviceInfo& DeviceInfo = GPUTestingEnvironment::GetInstance()->GetDevice()->GetDeviceInfo();
     if (!DeviceInfo.Features.AsyncShaderCompilation)
     {
         GTEST_SKIP() << "Async shader compilation is not supported by this device";
     }
 
-    auto pShader = CreateShader("AsyncShaderCompilationTest.psh", "Async pipeline test PS", SHADER_TYPE_PIXEL, SHADER_COMPILE_FLAG_ASYNCHRONOUS);
+    RefCntAutoPtr<IShader> pShader = CreateShader("AsyncShaderCompilationTest.psh", "Async pipeline test PS", SHADER_TYPE_PIXEL, SHADER_COMPILE_FLAG_ASYNCHRONOUS);
     ASSERT_NE(pShader, nullptr);
 
     // Release the shader while it is still compiling
@@ -147,8 +147,8 @@ void TestAsyncPipeline(SHADER_COMPILE_FLAGS ShaderFlags, PSO_CREATE_FLAGS PSOFla
 {
     GPUTestingEnvironment::ScopedReset EnvironmentAutoReset;
 
-    IRenderDevice* pDevice    = GPUTestingEnvironment::GetInstance()->GetDevice();
-    const auto&    DeviceInfo = pDevice->GetDeviceInfo();
+    IRenderDevice*          pDevice    = GPUTestingEnvironment::GetInstance()->GetDevice();
+    const RenderDeviceInfo& DeviceInfo = pDevice->GetDeviceInfo();
     if (!DeviceInfo.Features.AsyncShaderCompilation)
     {
         GTEST_SKIP() << "Async shader compilation is not supported by this device";
@@ -158,12 +158,12 @@ void TestAsyncPipeline(SHADER_COMPILE_FLAGS ShaderFlags, PSO_CREATE_FLAGS PSOFla
     {
         constexpr bool SimplifiedShader = true;
 
-        auto pVS = CreateShader("AsyncShaderCompilationTest.vsh", "Async pipeline test VS", SHADER_TYPE_VERTEX, ShaderFlags, SimplifiedShader);
+        RefCntAutoPtr<IShader> pVS = CreateShader("AsyncShaderCompilationTest.vsh", "Async pipeline test VS", SHADER_TYPE_VERTEX, ShaderFlags, SimplifiedShader);
         ASSERT_NE(pVS, nullptr);
 
         for (size_t i = 0; i < 16; ++i)
         {
-            auto pPS = CreateShader("AsyncShaderCompilationTest.psh", "Async pipeline test PS", SHADER_TYPE_PIXEL, ShaderFlags, SimplifiedShader);
+            RefCntAutoPtr<IShader> pPS = CreateShader("AsyncShaderCompilationTest.psh", "Async pipeline test PS", SHADER_TYPE_PIXEL, ShaderFlags, SimplifiedShader);
             ASSERT_NE(pPS, nullptr);
 
             // Allocate pipeline CI on the heap to check that all data is copied correctly
@@ -181,6 +181,7 @@ void TestAsyncPipeline(SHADER_COMPILE_FLAGS ShaderFlags, PSO_CREATE_FLAGS PSOFla
                 .AddShader(pVS)
                 .AddShader(pPS)
                 .AddRenderTarget(TEX_FORMAT_RGBA8_UNORM)
+                .SetDepthFormat(TEX_FORMAT_D32_FLOAT)
                 .SetInputLayout(InputLayout)
                 .SetResourceLayout(ResourceLayout)
                 .SetFlags(PSOFlags);
@@ -198,12 +199,12 @@ void TestAsyncPipeline(SHADER_COMPILE_FLAGS ShaderFlags, PSO_CREATE_FLAGS PSOFla
     }
 
     Timer  T;
-    auto   StartTime = T.GetElapsedTime();
+    double StartTime = T.GetElapsedTime();
     Uint32 Iter      = 0;
     while (true)
     {
         Uint32 NumPSOsReady = 0;
-        for (auto& pPSO : pPSOs)
+        for (RefCntAutoPtr<IPipelineState>& pPSO : pPSOs)
         {
             if (pPSO->GetStatus() == PIPELINE_STATE_STATUS_READY)
                 ++NumPSOsReady;

Tests/DiligentCoreAPITest/src/RenderStateCacheTest.cpp

@@ -534,6 +534,8 @@ void CreateGraphicsPSO(IRenderStateCache* pCache, bool PresentInCache, IShader*
         PsoCI.GraphicsPipeline.RTVFormats[0]    = ColorBufferFormat;
     }
 
+    PsoCI.GraphicsPipeline.DepthStencilDesc.DepthEnable = False;
+
     PsoCI.PSODesc.ResourceLayout = GetGraphicsPSOLayout();
 
     if (pCache != nullptr)

Tests/DiligentCoreAPITest/src/ShaderVariableAccessTest.cpp

@@ -1,5 +1,5 @@
 /*
- *  Copyright 2019-2024 Diligent Graphics LLC
+ *  Copyright 2019-2025 Diligent Graphics LLC
  *  Copyright 2015-2019 Egor Yusov
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
@@ -1319,6 +1319,8 @@ float4 main() : SV_Target
     GraphicsPipeline.NumRenderTargets = 1;
     GraphicsPipeline.RTVFormats[0]    = TEX_FORMAT_RGBA8_UNORM;
 
+    GraphicsPipeline.DepthStencilDesc.DepthEnable = False;
+
     PSOCreateInfo.pVS = pVS;
     PSOCreateInfo.pPS = pPS;