Skip to content

Commit 41edd7c

Browse files
Use SPIRVToolsInternal explicitly
1 parent 815c5c6 commit 41edd7c

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

Graphics/ShaderTools/src/ConvertUBOToPushConstant.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -424,13 +424,11 @@ std::vector<uint32_t> ConvertUBOToPushConstants(
424424
const std::vector<uint32_t>& SPIRV,
425425
const std::string& BlockName)
426426
{
427-
using namespace SPIRVToolsInternal;
428-
429-
spv_target_env TargetEnv = SpvTargetEnvFromSPIRV(SPIRV);
427+
spv_target_env TargetEnv = SPIRVToolsInternal::SpvTargetEnvFromSPIRV(SPIRV);
430428

431429
spvtools::Optimizer optimizer(TargetEnv);
432430

433-
optimizer.SetMessageConsumer(SpvOptimizerMessageConsumer);
431+
optimizer.SetMessageConsumer(SPIRVToolsInternal::SpvOptimizerMessageConsumer);
434432

435433
// Register the pass to convert UBO to push constant using custom out-of-tree pass
436434
optimizer.RegisterPass(spvtools::Optimizer::PassToken(

Graphics/ShaderTools/src/SPIRVTools.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,13 @@ spv_target_env SpvTargetEnvFromSPIRV(const std::vector<uint32_t>& SPIRV)
110110

111111
std::vector<uint32_t> OptimizeSPIRV(const std::vector<uint32_t>& SrcSPIRV, spv_target_env TargetEnv, SPIRV_OPTIMIZATION_FLAGS Passes)
112112
{
113-
using namespace SPIRVToolsInternal;
114-
115113
VERIFY_EXPR(Passes != SPIRV_OPTIMIZATION_FLAG_NONE);
116114

117115
if (TargetEnv == SPV_ENV_MAX)
118-
TargetEnv = SpvTargetEnvFromSPIRV(SrcSPIRV);
116+
TargetEnv = SPIRVToolsInternal::SpvTargetEnvFromSPIRV(SrcSPIRV);
119117

120118
spvtools::Optimizer SpirvOptimizer(TargetEnv);
121-
SpirvOptimizer.SetMessageConsumer(SpvOptimizerMessageConsumer);
119+
SpirvOptimizer.SetMessageConsumer(SPIRVToolsInternal::SpvOptimizerMessageConsumer);
122120

123121
spvtools::OptimizerOptions Options;
124122
#ifndef DILIGENT_DEVELOPMENT

0 commit comments

Comments
 (0)