GL: limit glGetError to device initialization in Release builds

Author: TheMostDiligent

Graphics/GraphicsEngineOpenGL/include/pch.h

@@ -153,10 +153,16 @@
     } while (false)
 
 #ifdef DILIGENT_DEVELOPMENT
-#    define DEV_CHECK_GL_ERROR CHECK_GL_ERROR
+#    define DEV_CHECK_GL_ERROR           CHECK_GL_ERROR
+#    define DEV_CHECK_GL_ERROR_AND_THROW CHECK_GL_ERROR_AND_THROW
 #else
 #    define DEV_CHECK_GL_ERROR(...) \
         do                          \
         {                           \
         } while (false)
+
+#    define DEV_CHECK_GL_ERROR_AND_THROW(...) \
+        do                                    \
+        {                                     \
+        } while (false)
 #endif

Graphics/GraphicsEngineOpenGL/src/BufferGLImpl.cpp

@@ -145,7 +145,7 @@ BufferGLImpl::BufferGLImpl(IReferenceCounters*        pRefCounters,
     // All buffer bind targets (GL_ARRAY_BUFFER, GL_ELEMENT_ARRAY_BUFFER etc.) relate to the same
     // kind of objects. As a result they are all equivalent from a transfer point of view.
     glBufferData(m_BindTarget, StaticCast<GLsizeiptr>(BuffDesc.Size), pData, m_GLUsageHint);
-    CHECK_GL_ERROR_AND_THROW("glBufferData() failed");
+    DEV_CHECK_GL_ERROR("glBufferData() failed");
     GLState.BindBuffer(m_BindTarget, GLObjectWrappers::GLBufferObj::Null(), ResetVAO);
 
     m_MemoryProperties = MEMORY_PROPERTY_HOST_COHERENT;

Graphics/GraphicsEngineOpenGL/src/BufferViewGLImpl.cpp

@@ -1,5 +1,5 @@
 /*
- *  Copyright 2019-2022 Diligent Graphics LLC
+ *  Copyright 2019-2024 Diligent Graphics LLC
  *  Copyright 2015-2019 Egor Yusov
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
@@ -95,7 +95,7 @@ BufferViewGLImpl::BufferViewGLImpl(IReferenceCounters*   pRefCounters,
                                 "Only full-buffer views can be created on this device.");
 #endif
         }
-        CHECK_GL_ERROR_AND_THROW("Failed to create texture buffer");
+        DEV_CHECK_GL_ERROR_AND_THROW("Failed to create texture buffer");
 
         CtxState.BindTexture(-1, GL_TEXTURE_BUFFER, GLObjectWrappers::GLTextureObj(false));
 

Graphics/GraphicsEngineOpenGL/src/SamplerGLImpl.cpp

@@ -122,7 +122,7 @@ SamplerGLImpl::SamplerGLImpl(IReferenceCounters* pRefCounters, class RenderDevic
     glSamplerParameterf(m_GlSampler, GL_TEXTURE_MAX_LOD, SamplerDesc.MaxLOD);
     glSamplerParameterf(m_GlSampler, GL_TEXTURE_MIN_LOD, SamplerDesc.MinLOD);
 
-    CHECK_GL_ERROR_AND_THROW("Failed to create OpenGL texture sampler\n");
+    DEV_CHECK_GL_ERROR_AND_THROW("Failed to create OpenGL texture sampler\n");
 
     m_GlSampler.SetName(m_Desc.Name);
 }

Graphics/GraphicsEngineOpenGL/src/Texture1DArray_GL.cpp

@@ -66,7 +66,7 @@ Texture1DArray_GL::Texture1DArray_GL(IReferenceCounters*        pRefCounters,
 
     //                             levels             format          width             height
     glTexStorage2D(m_BindTarget, m_Desc.MipLevels, m_GLTexFormat, m_Desc.Width, m_Desc.ArraySize);
-    CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 1D texture array");
+    DEV_CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 1D texture array");
     // When target is GL_TEXTURE_1D_ARRAY, calling glTexStorage2D() is equivalent to the following code:
     //for (i = 0; i < levels; i++)
     //{

Graphics/GraphicsEngineOpenGL/src/Texture1D_GL.cpp

@@ -65,7 +65,7 @@ Texture1D_GL::Texture1D_GL(IReferenceCounters*        pRefCounters,
 
     //                             levels             format          width
     glTexStorage1D(m_BindTarget, m_Desc.MipLevels, m_GLTexFormat, m_Desc.Width);
-    CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 1D texture");
+    DEV_CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 1D texture");
     // When target is GL_TEXTURE_1D, calling glTexStorage1D is equivalent to the following pseudo-code:
     //for (i = 0; i < levels; i++)
     //{

Graphics/GraphicsEngineOpenGL/src/Texture2DArray_GL.cpp

@@ -72,7 +72,7 @@ Texture2DArray_GL::Texture2DArray_GL(IReferenceCounters*        pRefCounters,
         // The last parameter specifies whether the image will use identical sample locations and the same number of
         // samples for all texels in the image, and the sample locations will not depend on the internal format or size
         // of the image.
-        CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 2D multisample texture array");
+        DEV_CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 2D multisample texture array");
         // * An INVALID_ENUM error is generated if sizedinternalformat is not colorrenderable,
         //   depth - renderable, or stencil - renderable
         // * An INVALID_OPERATION error is generated if samples is greater than the maximum number of samples
@@ -85,7 +85,7 @@ Texture2DArray_GL::Texture2DArray_GL(IReferenceCounters*        pRefCounters,
     {
         //                             levels             format          width         height          depth
         glTexStorage3D(m_BindTarget, m_Desc.MipLevels, m_GLTexFormat, m_Desc.Width, m_Desc.Height, m_Desc.ArraySize);
-        CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 2D texture array");
+        DEV_CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 2D texture array");
         // When target is GL_TEXTURE_2D_ARRAY, calling glTexStorage3D is equivalent to the following pseudo-code:
         //for (i = 0; i < levels; i++)
         //{

Graphics/GraphicsEngineOpenGL/src/Texture2D_GL.cpp

@@ -73,7 +73,7 @@ Texture2D_GL::Texture2D_GL(IReferenceCounters*        pRefCounters,
         // The last parameter specifies whether the image will use identical sample locations and the same number of
         // samples for all texels in the image, and the sample locations will not depend on the internal format or size
         // of the image.
-        CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 2D multisample texture");
+        DEV_CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 2D multisample texture");
         // * An INVALID_ENUM error is generated if sizedinternalformat is not colorrenderable,
         //   depth - renderable, or stencil - renderable
         // * An INVALID_OPERATION error is generated if samples is greater than the maximum number of samples
@@ -91,7 +91,7 @@ Texture2D_GL::Texture2D_GL(IReferenceCounters*        pRefCounters,
     {
         //                             levels             format          width         height
         glTexStorage2D(m_BindTarget, m_Desc.MipLevels, m_GLTexFormat, m_Desc.Width, m_Desc.Height);
-        CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 2D texture");
+        DEV_CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 2D texture");
         // When target is GL_TEXTURE_2D, calling glTexStorage2D is equivalent to the following pseudo-code:
         //for (i = 0; i < levels; i++)
         //{

Graphics/GraphicsEngineOpenGL/src/Texture3D_GL.cpp

@@ -67,7 +67,7 @@ Texture3D_GL::Texture3D_GL(IReferenceCounters*        pRefCounters,
 
     //                             levels             format          width        height          depth
     glTexStorage3D(m_BindTarget, m_Desc.MipLevels, m_GLTexFormat, m_Desc.Width, m_Desc.Height, m_Desc.Depth);
-    CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 3D texture");
+    DEV_CHECK_GL_ERROR_AND_THROW("Failed to allocate storage for the 3D texture");
     // When target is GL_TEXTURE_3D, calling glTexStorage3D is equivalent to the following pseudo-code:
     //for (i = 0; i < levels; i++)
     //{

Graphics/GraphicsEngineOpenGL/src/TextureBaseGL.cpp

@@ -464,7 +464,7 @@ void TextureBaseGL::CreateViewInternal(const TextureViewDesc& OrigViewDesc, ITex
                     LOG_ERROR_AND_THROW("glTextureView is not supported");
 
                 glTextureView(pViewOGL->GetHandle(), GLViewTarget, m_GlTexture, GLViewFormat, ViewDesc.MostDetailedMip, ViewDesc.NumMipLevels, ViewDesc.FirstArraySlice, NumLayers);
-                CHECK_GL_ERROR_AND_THROW("Failed to create texture view");
+                DEV_CHECK_GL_ERROR_AND_THROW("Failed to create texture view");
                 pViewOGL->SetBindTarget(GLViewTarget);
 
                 if (!IsIdentityComponentMapping(ViewDesc.Swizzle))