Skip to content

Commit 57b9bbf

Browse files
committed
We always need SPIRV-Tools to patch uniform buffer block, no matter NO_HLSL defined or not
1 parent de856be commit 57b9bbf

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

Graphics/GraphicsEngineVulkan/src/PipelineStateVkImpl.cpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,12 @@
4343
#include "EngineMemory.h"
4444
#include "StringTools.hpp"
4545

46-
#if !DILIGENT_NO_HLSL
47-
# include "SPIRVTools.hpp"
48-
#endif
46+
//We always need this to patch uniform buffer block, no matter DILIGENT_NO_HLSL defined or not.
47+
#include "SPIRVTools.hpp"
4948

5049
namespace Diligent
5150
{
5251

53-
//when DILIGENT_NO_HLSL not defined
54-
std::vector<uint32_t> PatchSPIRVConvertUniformBufferToPushConstant(const std::vector<uint32_t>& SPIRV,
55-
const std::string& BlockName);
56-
5752
constexpr INTERFACE_ID PipelineStateVkImpl::IID_InternalImpl;
5853

5954
namespace

Graphics/ShaderTools/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ if(DILIGENT_USE_SPIRV_TOOLCHAIN)
106106
set(USE_SPIRV_TOOLS TRUE)
107107
endif()
108108
endif()
109-
if (NOT ${DILIGENT_NO_HLSL} AND TARGET SPIRV-Tools-opt)
109+
if (TARGET SPIRV-Tools-opt) # NOT ${DILIGENT_NO_HLSL} AND -- we always need SPIRV-Tools.
110110
set(USE_SPIRV_TOOLS TRUE)
111111
endif()
112112
endif()

0 commit comments

Comments
 (0)