Skip to content

Commit 67e54ee

Browse files
D3DTypeConversions: don't use auto where unnecessary
1 parent 6055fdf commit 67e54ee

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed

Graphics/GraphicsEngineD3DBase/include/D3DTypeConversionImpl.hpp

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2019-2022 Diligent Graphics LLC
2+
* Copyright 2019-2025 Diligent Graphics LLC
33
* Copyright 2015-2019 Egor Yusov
44
*
55
* Licensed under the Apache License, Version 2.0 (the "License");
@@ -154,7 +154,7 @@ D3D_FILL_MODE FillModeToD3DFillMode(FILL_MODE FillMode)
154154
}
155155
if (FILL_MODE_UNDEFINED < FillMode && FillMode < FILL_MODE_NUM_MODES)
156156
{
157-
auto d3dFillMode = d3dFillModes[FillMode];
157+
D3D_FILL_MODE d3dFillMode = d3dFillModes[FillMode];
158158
VERIFY(d3dFillMode != 0, "Incorrect fill mode");
159159
return d3dFillMode;
160160
}
@@ -182,7 +182,7 @@ D3D_CULL_MODE CullModeToD3DCullMode(CULL_MODE CullMode)
182182

183183
if (CULL_MODE_UNDEFINED < CullMode && CullMode < CULL_MODE_NUM_MODES)
184184
{
185-
auto d3dCullMode = d3dCullModes[CullMode];
185+
D3D_CULL_MODE d3dCullMode = d3dCullModes[CullMode];
186186
VERIFY(d3dCullMode != 0, "Incorrect cull mode");
187187
return d3dCullMode;
188188
}
@@ -253,7 +253,7 @@ D3D_BLEND BlendFactorToD3DBlend(BLEND_FACTOR bf)
253253
}
254254
if (bf > BLEND_FACTOR_UNDEFINED && bf < BLEND_FACTOR_NUM_FACTORS)
255255
{
256-
auto d3dbf = D3DBlend[bf];
256+
D3D_BLEND d3dbf = D3DBlend[bf];
257257
VERIFY(d3dbf != 0, "Incorrect blend factor");
258258
return d3dbf;
259259
}
@@ -286,7 +286,7 @@ D3D_BLEND_OP BlendOperationToD3DBlendOp(BLEND_OPERATION BlendOp)
286286

287287
if (BlendOp > BLEND_OPERATION_UNDEFINED && BlendOp < BLEND_OPERATION_NUM_OPERATIONS)
288288
{
289-
auto d3dbop = D3DBlendOp[BlendOp];
289+
D3D_BLEND_OP d3dbop = D3DBlendOp[BlendOp];
290290
VERIFY(d3dbop != 0, "Incorrect blend operation");
291291
return d3dbop;
292292
}
@@ -306,8 +306,9 @@ void BlendStateDescToD3DBlendDesc(const BlendStateDesc& BSDesc, D3D_BLEND_DESC&
306306
VERIFY(MAX_RENDER_TARGETS >= 8, "Number of render targets is expected to be at least 8");
307307
for (int i = 0; i < 8; ++i)
308308
{
309-
const auto& SrcRTDesc = BSDesc.RenderTargets[i];
310-
auto& DstRTDesc = d3d12BlendDesc.RenderTarget[i];
309+
const RenderTargetBlendDesc& SrcRTDesc = BSDesc.RenderTargets[i];
310+
auto& DstRTDesc = d3d12BlendDesc.RenderTarget[i];
311+
311312
DstRTDesc.BlendEnable = SrcRTDesc.BlendEnable ? TRUE : FALSE;
312313

313314
DstRTDesc.SrcBlend = BlendFactorToD3DBlend<D3D_BLEND>(SrcRTDesc.SrcBlend);
@@ -353,7 +354,7 @@ D3D_STENCIL_OP StencilOpToD3DStencilOp(STENCIL_OP StencilOp)
353354

354355
if (StencilOp > STENCIL_OP_UNDEFINED && StencilOp < STENCIL_OP_NUM_OPS)
355356
{
356-
auto d3dStencilOp = StOpToD3DStOpMap[StencilOp];
357+
D3D_STENCIL_OP d3dStencilOp = StOpToD3DStOpMap[StencilOp];
357358
VERIFY(d3dStencilOp != 0, "Unexpected stencil op");
358359
return d3dStencilOp;
359360
}
@@ -400,15 +401,15 @@ void LayoutElements_To_D3D_INPUT_ELEMENT_DESCs(const InputLayoutDesc&
400401
D3DInputElements.resize(InputLayout.NumElements);
401402
for (Uint32 iElem = 0; iElem < InputLayout.NumElements; ++iElem)
402403
{
403-
const auto& CurrElem = InputLayout.LayoutElements[iElem];
404-
auto& D3DElem = D3DInputElements[iElem];
405-
D3DElem.SemanticName = CurrElem.HLSLSemantic;
406-
D3DElem.SemanticIndex = CurrElem.InputIndex;
407-
D3DElem.AlignedByteOffset = CurrElem.RelativeOffset;
408-
D3DElem.InputSlot = CurrElem.BufferSlot;
409-
D3DElem.Format = TypeToDXGI_Format(CurrElem.ValueType, CurrElem.NumComponents, CurrElem.IsNormalized);
410-
D3DElem.InputSlotClass = (CurrElem.Frequency == INPUT_ELEMENT_FREQUENCY_PER_VERTEX) ? D3D_INPUT_CLASSIFICATION_PER_VERTEX_DATA : D3D_INPUT_CLASSIFICATION_PER_INSTANCE_DATA;
411-
D3DElem.InstanceDataStepRate = (CurrElem.Frequency == INPUT_ELEMENT_FREQUENCY_PER_VERTEX) ? 0 : CurrElem.InstanceDataStepRate;
404+
const LayoutElement& CurrElem = InputLayout.LayoutElements[iElem];
405+
D3D_INPUT_ELEMENT_DESC& D3DElem = D3DInputElements[iElem];
406+
D3DElem.SemanticName = CurrElem.HLSLSemantic;
407+
D3DElem.SemanticIndex = CurrElem.InputIndex;
408+
D3DElem.AlignedByteOffset = CurrElem.RelativeOffset;
409+
D3DElem.InputSlot = CurrElem.BufferSlot;
410+
D3DElem.Format = TypeToDXGI_Format(CurrElem.ValueType, CurrElem.NumComponents, CurrElem.IsNormalized);
411+
D3DElem.InputSlotClass = (CurrElem.Frequency == INPUT_ELEMENT_FREQUENCY_PER_VERTEX) ? D3D_INPUT_CLASSIFICATION_PER_VERTEX_DATA : D3D_INPUT_CLASSIFICATION_PER_INSTANCE_DATA;
412+
D3DElem.InstanceDataStepRate = (CurrElem.Frequency == INPUT_ELEMENT_FREQUENCY_PER_VERTEX) ? 0 : CurrElem.InstanceDataStepRate;
412413
}
413414
}
414415

0 commit comments

Comments
 (0)