Improve inline constants resource description validation (#672)

Author: TheMostDiligent

Graphics/GraphicsEngine/src/PipelineResourceSignatureBase.cpp

@@ -111,10 +111,24 @@ void ValidatePipelineResourceSignatureDesc(const PipelineResourceSignatureDesc&
                                     ": ", GetPipelineResourceFlagsString(AllowedResourceFlags, false, ", "), ".");
         }
 
-        if ((Res.Flags & PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS) != 0 && Res.Flags != PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS)
+        if ((Res.Flags & PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS) != 0)
         {
-            LOG_PRS_ERROR_AND_THROW("Incorrect Desc.Resources[", i, "].Flags (", GetPipelineResourceFlagsString(Res.Flags),
-                                    "). INLINE_CONSTANTS flag cannot be combined with other flags.");
+            if (Res.Flags != PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS)
+            {
+                LOG_PRS_ERROR_AND_THROW("Incorrect Desc.Resources[", i, "].Flags (", GetPipelineResourceFlagsString(Res.Flags),
+                                        "). INLINE_CONSTANTS flag cannot be combined with other flags.");
+            }
+
+            if (Res.ArraySize == 0)
+            {
+                LOG_PRS_ERROR_AND_THROW("Desc.Resources[", i, "].ArraySize must be greater than 0 for inline constants.");
+            }
+
+            if (Res.ArraySize > 64)
+            {
+                LOG_PRS_ERROR_AND_THROW("Desc.Resources[", i, "].ArraySize (", Res.ArraySize,
+                                        ") exceeds the maximum allowed value (64) for inline constants.");
+            }
         }
 
         if ((Res.Flags & PIPELINE_RESOURCE_FLAG_FORMATTED_BUFFER) != 0 && Features.FormattedBuffers == DEVICE_FEATURE_STATE_DISABLED)

Tests/DiligentCoreAPITest/src/InlineConstantsTest.cpp

@@ -191,7 +191,7 @@ TEST_F(InlineConstants, ResourceSignature)
             SHADER_RESOURCE_VARIABLE_TYPE PosType = static_cast<SHADER_RESOURCE_VARIABLE_TYPE>(pos_type);
             SHADER_RESOURCE_VARIABLE_TYPE ColType = static_cast<SHADER_RESOURCE_VARIABLE_TYPE>(col_type);
 
-            PipelineResourceSignatureDescX SignDesc;
+            PipelineResourceSignatureDescX SignDesc{"Inline constants test"};
             SignDesc
                 .AddResource(SHADER_TYPE_VERTEX, "cb0_stat", 1u, SHADER_RESOURCE_TYPE_CONSTANT_BUFFER, SHADER_RESOURCE_VARIABLE_TYPE_STATIC)
                 .AddResource(SHADER_TYPE_VERTEX, "cb0_mut", 1u, SHADER_RESOURCE_TYPE_CONSTANT_BUFFER, SHADER_RESOURCE_VARIABLE_TYPE_MUTABLE)