Vulkan swap chain: removed image acquire status debug checks (fix #632)

The image may be immediately out of date after it is acquired

Author: TheMostDiligent

Graphics/GraphicsEngineVulkan/src/SwapChainVkImpl.cpp

@@ -54,9 +54,9 @@ SwapChainVkImpl::SwapChainVkImpl(IReferenceCounters*  pRefCounters,
     CreateSurface();
     CreateVulkanSwapChain();
     InitBuffersAndViews();
-    VkResult res = AcquireNextImage(pDeviceContextVk);
-    DEV_CHECK_ERR(res == VK_SUCCESS, "Failed to acquire next image for the newly created swap chain");
-    (void)res;
+
+    AcquireNextImage(pDeviceContextVk);
+    // Note that the image may be immediately out of date.
 
     FenceDesc FenceCI;
     FenceCI.Name = "Swap chain frame complete fence";
@@ -620,7 +620,7 @@ VkResult SwapChainVkImpl::AcquireNextImage(DeviceContextVkImpl* pDeviceCtxVk)
     RefCntAutoPtr<ManagedSemaphore>& ImageAcquiredSemaphore = m_ImageAcquiredSemaphores[m_SemaphoreIndex];
 
     VkResult res = vkAcquireNextImageKHR(LogicalDevice.GetVkDevice(), m_VkSwapChain, UINT64_MAX, ImageAcquiredSemaphore->Get(), VK_NULL_HANDLE, &m_BackBufferIndex);
-    if (res == VK_SUCCESS)
+    if (res == VK_SUCCESS || res == VK_SUBOPTIMAL_KHR)
     {
         // Next command in the device context must wait for the next image to be acquired.
         // Unlike fences or events, the act of waiting for a semaphore also unsignals that semaphore.
@@ -745,7 +745,7 @@ void SwapChainVkImpl::Present(Uint32 SyncInterval)
             }
 #endif
         }
-        DEV_CHECK_ERR(res == VK_SUCCESS, "Failed to acquire next swap chain image");
+        // The image may still be out of date if the window keeps changing size
     }
 }
 
@@ -919,9 +919,8 @@ void SwapChainVkImpl::Resize(Uint32 NewWidth, Uint32 NewHeight, SURFACE_TRANSFOR
                 // RecreateVulkanSwapchain() unbinds default FB
                 RecreateVulkanSwapchain(pImmediateCtxVk);
 
-                VkResult res = AcquireNextImage(pImmediateCtxVk);
-                DEV_CHECK_ERR(res == VK_SUCCESS, "Failed to acquire next image for the just resized swap chain");
-                (void)res;
+                AcquireNextImage(pImmediateCtxVk);
+                // The image may be immediately out of date if the window keeps being resized
             }
             catch (const std::runtime_error&)
             {