CMake: improved windows SDK directory detection (#467)

Read the Windows Kits roots location from the registry
to make the path available at configuration time and
not rely on the $(WindowsSdkDir) VS-only env variable

Author: TheMostDiligent

CMakeLists.txt

@@ -101,6 +101,7 @@ endif()
 message("CMake generator: " ${CMAKE_GENERATOR})
 
 if(WIN32)
+    # Determine Windows SDK version
     if (CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION)
         set(WINDOWS_SDK_VERSION ${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION} CACHE INTERNAL "Windows SDK version")
     elseif(DEFINED ENV{WindowsSDKVersion})
@@ -113,13 +114,56 @@ if(WIN32)
         message(WARNING "Unable to determine Windows SDK version: neither the CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION CMake variable nor the WindowsSDKVersion environment variable is set")
     endif()
 
+    # Get Windows SDK bin directory
+    if ("${WINDOWS_SDK_VERSION}" VERSION_GREATER_EQUAL "10.0")
+        get_filename_component(
+        WINDOWS_KITS_ROOT
+            "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows Kits\\Installed Roots;KitsRoot10]"
+            ABSOLUTE
+        )
+        if (NOT WINDOWS_KITS_ROOT)
+            message(ERROR "Unable to read Windows SDK root directory from registry")
+        elseif(NOT EXISTS "${WINDOWS_KITS_ROOT}")
+            message(ERROR "Windows SDK root directory does not exist: " ${WINDOWS_KITS_ROOT})
+            unset(WINDOWS_KITS_ROOT)
+        endif()
+
+        if(WINDOWS_KITS_ROOT)
+            # NOTE: CMAKE_GENERATOR_PLATFORM is not set for single-configuration generators (e.g. Makefile, Ninja)
+            if (${CMAKE_SIZEOF_VOID_P} EQUAL 8)
+                if ("${TARGET_CPU}" STREQUAL "arm")
+                    set(ARCH_SUFFIX "arm64")
+                else()
+                    set(ARCH_SUFFIX "x64")
+                endif()
+            else()
+                if ("${TARGET_CPU}" STREQUAL "arm")
+                    set(ARCH_SUFFIX "arm")
+                else()
+                    set(ARCH_SUFFIX "x86")
+                endif()
+            endif()
+
+            set(WINDOWS_SDK_BIN_DIR "${WINDOWS_KITS_ROOT}/bin/${WINDOWS_SDK_VERSION}/${ARCH_SUFFIX}")
+            if (EXISTS "${WINDOWS_SDK_BIN_DIR}")
+                set(WINDOWS_SDK_BIN_DIR "${WINDOWS_SDK_BIN_DIR}" CACHE INTERNAL "Windows SDK bin directory")
+            else()
+                message(ERROR "Windows SDK bin directory does not exist: " ${WINDOWS_SDK_BIN_DIR})
+			    unset(WINDOWS_SDK_BIN_DIR)
+            endif()
+        endif()
+    endif()
+
     if(${CMAKE_SYSTEM_NAME} STREQUAL "WindowsStore")
         set(PLATFORM_UNIVERSAL_WINDOWS TRUE CACHE INTERNAL "Target platform: Windows Store")
         message("Target platform: Universal Windows " ${ARCH} ". Windows SDK Version: " ${WINDOWS_SDK_VERSION})
     else()
         set(PLATFORM_WIN32 TRUE CACHE INTERNAL "Target platform: Win32") #WIN32 is a variable, so we cannot use string "WIN32"
         message("Target platform: Win32 " ${ARCH} ". Windows SDK Version: " ${WINDOWS_SDK_VERSION})
     endif()
+    if(WINDOWS_SDK_BIN_DIR)
+        message("Windows SDK bin directory: " ${WINDOWS_SDK_BIN_DIR})
+    endif()
 else()
     if(${CMAKE_SYSTEM_NAME} STREQUAL "Android")
         set(PLATFORM_ANDROID TRUE CACHE INTERNAL "Target platform: Android")

Graphics/GraphicsEngineD3DBase/CMakeLists.txt

@@ -81,19 +81,13 @@ if(MSVC)
 
     # Note that CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION is stated to be defined when targeting Windows 10
     # and above, however it is also defined when targeting 8.1 and Visual Studio 2019 (but not VS2017)
-    if("${WINDOWS_SDK_VERSION}" VERSION_GREATER_EQUAL "10.0")
-        if (DEFINED CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION)
-            # Note that VS_WINDOWS_SDK_BIN_DIR as well as all derived paths can only be used in Visual Studio
-            # commands and are not valid paths during CMake configuration
-            set(VS_WINDOWS_SDK_BIN_DIR "$(WindowsSdkDir)\\bin\\${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION}\\${ARCH_SUFFIX}")
-
-            set(VS_D3D_COMPILER_PATH "\"${VS_WINDOWS_SDK_BIN_DIR}\\D3Dcompiler_47.dll\"" CACHE INTERNAL "D3Dcompiler_47.dll path")
-
-            # DXC is only present in Windows SDK starting with version 10.0.17763.0
-            if(${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION} VERSION_GREATER_EQUAL "10.0.17763.0")
-                set(VS_DXC_COMPILER_PATH "\"${VS_WINDOWS_SDK_BIN_DIR}\\dxcompiler.dll\"" CACHE INTERNAL "dxcompiler.dll path")
-                set(VS_DXIL_SIGNER_PATH  "\"${VS_WINDOWS_SDK_BIN_DIR}\\dxil.dll\"" CACHE INTERNAL "dxil.dll path")
-            endif()
+    if("${WINDOWS_SDK_VERSION}" VERSION_GREATER_EQUAL "10.0" AND WINDOWS_SDK_BIN_DIR)
+        set(VS_D3D_COMPILER_PATH "\"${WINDOWS_SDK_BIN_DIR}\\D3Dcompiler_47.dll\"" CACHE INTERNAL "D3Dcompiler_47.dll path")
+
+        # DXC is only present in Windows SDK starting with version 10.0.17763.0
+        if("${WINDOWS_SDK_VERSION}" VERSION_GREATER_EQUAL "10.0.17763.0")
+            set(VS_DXC_COMPILER_PATH "\"${WINDOWS_SDK_BIN_DIR}\\dxcompiler.dll\"" CACHE INTERNAL "dxcompiler.dll path")
+            set(VS_DXIL_SIGNER_PATH  "\"${WINDOWS_SDK_BIN_DIR}\\dxil.dll\"" CACHE INTERNAL "dxil.dll path")
         endif()
     elseif("${WINDOWS_SDK_VERSION}" VERSION_EQUAL "8.1")
         # D3Dcompiler_47.dll from Win8.1 SDK is ancient (from 2013) and fails to