Added more clear render target tests

Author: TheMostDiligent

Graphics/GraphicsEngine/include/DeviceContextBase.hpp

@@ -1608,10 +1608,10 @@ inline void DeviceContextBase<ImplementationTraits>::ClearDepthStencil(ITextureV
             }
             else
             {
-                LOG_WARNING_MESSAGE("Depth-stencil view '", ViewDesc.Name,
-                                    "' is not bound to the device context. "
-                                    "ClearDepthStencil command is more efficient when depth-stencil "
-                                    "view is bound to the context. In OpenGL backend this is a requirement.");
+                LOG_DVP_WARNING_MESSAGE("Depth-stencil view '", ViewDesc.Name,
+                                        "' is not bound to the device context. "
+                                        "ClearDepthStencil command is more efficient when depth-stencil "
+                                        "view is bound to the context. In OpenGL, Metal and WebGPU backends this is required.");
             }
         }
     }
@@ -1654,9 +1654,9 @@ inline void DeviceContextBase<ImplementationTraits>::ClearRenderTarget(ITextureV
             }
             else
             {
-                LOG_WARNING_MESSAGE("Render target view '", ViewDesc.Name,
-                                    "' is not bound to the device context. ClearRenderTarget command is more efficient "
-                                    "if render target view is bound to the device context. In OpenGL backend this is a requirement.");
+                LOG_DVP_WARNING_MESSAGE("Render target view '", ViewDesc.Name,
+                                        "' is not bound to the device context. ClearRenderTarget command is more efficient "
+                                        "if render target view is bound to the device context. In OpenGL, Metal and WebGPU backends this is required.");
             }
         }
     }

Graphics/GraphicsEngineVulkan/src/DeviceContextVkImpl.cpp

@@ -1325,7 +1325,7 @@ void DeviceContextVkImpl::ClearRenderTarget(ITextureView* pView, const void* RGB
             ClearRect.baseArrayLayer = 0;
             ClearRect.layerCount     = ViewDesc.NumArraySlices;
             // No memory barriers are needed between vkCmdClearAttachments and preceding or
-            // subsequent draw or attachment clear commands in the same subpass (17.2)
+            // subsequent draw or attachment clear commands in the same subpass
             m_CommandBuffer.ClearAttachment(ClearAttachment, ClearRect);
         }
     }
@@ -1339,7 +1339,7 @@ void DeviceContextVkImpl::ClearRenderTarget(ITextureView* pView, const void* RGB
         ITexture*      pTexture   = pVkRTV->GetTexture();
         TextureVkImpl* pTextureVk = ClassPtrCast<TextureVkImpl>(pTexture);
 
-        // Image layout must be VK_IMAGE_LAYOUT_GENERAL or VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL (17.1)
+        // Image layout must be VK_IMAGE_LAYOUT_GENERAL or VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL
         TransitionOrVerifyTextureState(*pTextureVk, StateTransitionMode, RESOURCE_STATE_COPY_DEST, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
                                        "Clearing render target outside of render pass (DeviceContextVkImpl::ClearRenderTarget)");
 

Tests/DiligentCoreAPITest/src/ClearRenderTargetTest.cpp

@@ -163,6 +163,34 @@ TEST(ClearRenderTargetTest, AsRenderTarget)
 }
 
 
+TEST(ClearRenderTargetTest, AsUnboundRenderTarget)
+{
+    GPUTestingEnvironment*  pEnv       = GPUTestingEnvironment::GetInstance();
+    IRenderDevice*          pDevice    = pEnv->GetDevice();
+    const RenderDeviceInfo& DeviceInfo = pDevice->GetDeviceInfo();
+    if (!(DeviceInfo.IsD3DDevice() || DeviceInfo.IsVulkanDevice()))
+    {
+        GTEST_SKIP() << "Clearing unbound render target is only supported in Direct3D and Vulkan";
+    }
+
+    ISwapChain*     pSwapChain = pEnv->GetSwapChain();
+    IDeviceContext* pContext   = pEnv->GetDeviceContext();
+
+    GPUTestingEnvironment::ScopedReset EnvironmentAutoReset;
+
+    constexpr float ClearColor[] = {0.25f, 0.5f, 0.75f, 1.0f};
+    ReferenceClear(ClearColor);
+
+    pContext->SetRenderTargets(0, nullptr, nullptr, RESOURCE_STATE_TRANSITION_MODE_TRANSITION);
+    pContext->ClearRenderTarget(pSwapChain->GetCurrentBackBufferRTV(), ClearColor, RESOURCE_STATE_TRANSITION_MODE_TRANSITION);
+
+    pSwapChain->Present();
+
+    TestSwapChainCInterface(pSwapChain);
+}
+
+
+
 TEST(ClearRenderTargetTest, ClearAfterClear)
 {
     GPUTestingEnvironment* pEnv       = GPUTestingEnvironment::GetInstance();
@@ -184,6 +212,46 @@ TEST(ClearRenderTargetTest, ClearAfterClear)
 }
 
 
+
+TEST(ClearRenderTargetTest, UnboundClearAfterClear)
+{
+    GPUTestingEnvironment*  pEnv       = GPUTestingEnvironment::GetInstance();
+    IRenderDevice*          pDevice    = pEnv->GetDevice();
+    const RenderDeviceInfo& DeviceInfo = pDevice->GetDeviceInfo();
+    if (!(DeviceInfo.IsD3DDevice() || DeviceInfo.IsVulkanDevice()))
+    {
+        GTEST_SKIP() << "Clearing unbound render target is only supported in Direct3D and Vulkan";
+    }
+
+    ISwapChain*     pSwapChain = pEnv->GetSwapChain();
+    IDeviceContext* pContext   = pEnv->GetDeviceContext();
+
+    GPUTestingEnvironment::ScopedReset EnvironmentAutoReset;
+
+    constexpr float ClearColor0[] = {0.125f, 0.5f, 0.75f, 1.0f};
+    constexpr float ClearColor1[] = {0.25f, 0.75f, 0.875f, 1.0f};
+    ReferenceClear(ClearColor0);
+
+    ITextureView* pRTVs[] = {pSwapChain->GetCurrentBackBufferRTV()};
+    pContext->SetRenderTargets(1, pRTVs, nullptr, RESOURCE_STATE_TRANSITION_MODE_TRANSITION);
+    pContext->ClearRenderTarget(pRTVs[0], ClearColor0, RESOURCE_STATE_TRANSITION_MODE_TRANSITION);
+
+    TextureDesc TexDesc;
+    TexDesc.Name      = "ClearRenderTargetTest.UnboundClearAfterClear";
+    TexDesc.Type      = RESOURCE_DIM_TEX_2D;
+    TexDesc.Width     = 512;
+    TexDesc.Height    = 512;
+    TexDesc.Format    = TEX_FORMAT_RGBA8_UNORM;
+    TexDesc.BindFlags = BIND_RENDER_TARGET;
+    RefCntAutoPtr<ITexture> pTex;
+    pEnv->GetDevice()->CreateTexture(TexDesc, nullptr, &pTex);
+    ASSERT_NE(pTex, nullptr);
+    pContext->ClearRenderTarget(pTex->GetDefaultView(TEXTURE_VIEW_RENDER_TARGET), ClearColor1, RESOURCE_STATE_TRANSITION_MODE_TRANSITION);
+
+    pSwapChain->Present();
+}
+
+
 TEST(ClearRenderTargetTest, ResetRTsAfterClear)
 {
     GPUTestingEnvironment* pEnv       = GPUTestingEnvironment::GetInstance();