Skip to content

Commit c090a57

Browse files
CMake: use namespaces for volk and Vulkan-Headers targets
1 parent 573955f commit c090a57

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

Graphics/Archiver/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ if(D3D12_SUPPORTED)
112112
endif()
113113

114114
if(VULKAN_SUPPORTED)
115-
target_link_libraries(Diligent-Archiver-static PRIVATE Diligent-GraphicsEngineVk-static Vulkan-Headers)
115+
target_link_libraries(Diligent-Archiver-static PRIVATE Diligent-GraphicsEngineVk-static Vulkan::Headers)
116116
target_include_directories(Diligent-Archiver-static
117117
PRIVATE
118118
../GraphicsEngineVulkan/include

Graphics/GraphicsEngineVulkan/CMakeLists.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ set(PRIVATE_DEPENDENCIES
172172
Diligent-TargetPlatform
173173
Diligent-GraphicsEngineNextGenBase
174174
Diligent-ShaderTools
175-
Vulkan-Headers
175+
Vulkan::Headers
176176
)
177177

178178
if (${DILIGENT_NO_HLSL})
@@ -246,19 +246,19 @@ else()
246246
endif()
247247

248248
if(PLATFORM_WIN32)
249-
list(APPEND PRIVATE_DEPENDENCIES volk_headers)
249+
list(APPEND PRIVATE_DEPENDENCIES volk::volk_headers)
250250
elseif(PLATFORM_MACOS)
251-
list(APPEND PRIVATE_DEPENDENCIES volk_headers)
251+
list(APPEND PRIVATE_DEPENDENCIES volk::volk_headers)
252252
elseif(PLATFORM_IOS OR PLATFORM_TVOS)
253253
find_library(CORE_GRAPHICS CoreGraphics)
254254
find_library(METAL_LIBRARY Metal)
255255
find_library(QUARTZ_CORE QuartzCore)
256256
find_library(UI_KIT UIKit)
257257
list(APPEND PRIVATE_DEPENDENCIES ${MOLTENVK_LIBRARY} ${CORE_GRAPHICS} ${METAL_LIBRARY} ${QUARTZ_CORE} ${UI_KIT})
258258
elseif(PLATFORM_LINUX)
259-
list(APPEND PRIVATE_DEPENDENCIES volk_headers)
259+
list(APPEND PRIVATE_DEPENDENCIES volk::volk_headers)
260260
elseif(PLATFORM_ANDROID)
261-
list(APPEND PRIVATE_DEPENDENCIES volk_headers)
261+
list(APPEND PRIVATE_DEPENDENCIES volk::volk_headers)
262262
else()
263263
find_library(Vulkan_LIBRARY NAMES vulkan)
264264
list(APPEND PRIVATE_DEPENDENCIES ${Vulkan_LIBRARY})

Tests/GPUTestFramework/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ if(PLATFORM_LINUX)
9999
endif()
100100

101101
if(VULKAN_SUPPORTED)
102-
target_link_libraries(Diligent-GPUTestFramework PUBLIC Vulkan-Headers volk_headers)
103-
102+
target_link_libraries(Diligent-GPUTestFramework PUBLIC Vulkan::Headers volk::volk_headers)
103+
104104
if(PLATFORM_LINUX)
105105
target_link_libraries(Diligent-GPUTestFramework
106106
PUBLIC

ThirdParty/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,13 @@ if (VULKAN_SUPPORTED OR METAL_SUPPORTED)
3131
endif()
3232
install(FILES "${SPIRV-Headers_SOURCE_DIR}/LICENSE" DESTINATION "Licenses/ThirdParty/${DILIGENT_CORE_DIR}" RENAME SPIRV-Headers-License.txt)
3333

34-
if (NOT TARGET Vulkan-Headers)
34+
if (NOT TARGET Vulkan::Headers)
3535
# Manually add the Vulkan-Headers target as this is all we need and the
3636
# project's CMake creates unnecessary targets
3737
add_library(Vulkan-Headers INTERFACE)
3838
# Vulkan-Headers_SOURCE_DIR variable is normally created by project(Vulkan-Headers)
3939
set(Vulkan-Headers_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/Vulkan-Headers")
40+
add_library(Vulkan::Headers ALIAS Vulkan-Headers)
4041
target_include_directories(Vulkan-Headers INTERFACE "${Vulkan-Headers_SOURCE_DIR}/include")
4142
endif()
4243
install(FILES "${Vulkan-Headers_SOURCE_DIR}/LICENSE.txt" DESTINATION "Licenses/ThirdParty/${DILIGENT_CORE_DIR}" RENAME Vulkan-Headers-License.txt)
@@ -133,7 +134,7 @@ if (VULKAN_SUPPORTED OR METAL_SUPPORTED)
133134
endif()
134135

135136
if (VULKAN_SUPPORTED AND (PLATFORM_WIN32 OR PLATFORM_LINUX OR PLATFORM_MACOS OR PLATFORM_ANDROID))
136-
if (NOT TARGET volk)
137+
if (NOT TARGET volk::volk)
137138
set(VOLK_PULL_IN_VULKAN OFF)
138139
set(VOLK_INSTALL OFF)
139140
add_subdirectory(volk)

0 commit comments

Comments
 (0)