Skip to content

Commit c2a8c2d

Browse files
Disabled format validations on platforms that don't have format validation script
1 parent ec69aba commit c2a8c2d

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

BuildTools/CMake/BuildUtils.cmake

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -399,20 +399,22 @@ function(add_format_validation_target MODULE_NAME MODULE_ROOT_PATH IDE_FOLDER)
399399
set(RUN_VALIDATION_SCRIPT ./validate_format_linux.sh)
400400
elseif(CMAKE_HOST_SYSTEM_NAME STREQUAL "Darwin")
401401
set(RUN_VALIDATION_SCRIPT ./validate_format_mac.sh)
402-
else()
403-
message(FATAL_ERROR "Unexpected host system")
404402
endif()
405403

406-
# Run the format validation script
407-
add_custom_command(TARGET ${MODULE_NAME}-ValidateFormatting
408-
COMMAND ${RUN_VALIDATION_SCRIPT}
409-
WORKING_DIRECTORY "${MODULE_ROOT_PATH}/BuildTools/FormatValidation"
410-
COMMENT "Validating ${MODULE_NAME} module's source code formatting..."
411-
VERBATIM
412-
)
404+
if (RUN_VALIDATION_SCRIPT)
405+
# Run the format validation script
406+
add_custom_command(TARGET ${MODULE_NAME}-ValidateFormatting
407+
COMMAND ${RUN_VALIDATION_SCRIPT}
408+
WORKING_DIRECTORY "${MODULE_ROOT_PATH}/BuildTools/FormatValidation"
409+
COMMENT "Validating ${MODULE_NAME} module's source code formatting..."
410+
VERBATIM
411+
)
413412

414-
if(TARGET ${MODULE_NAME}-ValidateFormatting)
415-
set_target_properties(${MODULE_NAME}-ValidateFormatting PROPERTIES FOLDER ${IDE_FOLDER})
413+
if(TARGET ${MODULE_NAME}-ValidateFormatting)
414+
set_target_properties(${MODULE_NAME}-ValidateFormatting PROPERTIES FOLDER ${IDE_FOLDER})
415+
endif()
416+
else()
417+
message(DEBUG "${MODULE_NAME}-ValidateFormatting target will be disabled because format validation script is not available on ${CMAKE_HOST_SYSTEM_NAME} host platform.")
416418
endif()
417419

418420
endfunction()

0 commit comments

Comments
 (0)