Skip to content

Commit c84f619

Browse files
committed
Don't filter out SRBs that only have push constants (no descriptor sets), cuz we no longer filter out push constants when creating layout.
1 parent 3520519 commit c84f619

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

Graphics/GraphicsEngineVulkan/src/DeviceContextVkImpl.cpp

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -513,27 +513,6 @@ void DeviceContextVkImpl::CommitDescriptorSets(ResourceBindInfo& BindInfo, Uint3
513513
{
514514
VERIFY(CommitSRBMask != 0, "This method should not be called when there is nothing to commit");
515515

516-
// Filter out SRBs that only have push constants (no descriptor sets)
517-
// These SRBs are included in CommitSRBMask due to InlineConstantsSRBMask, but they don't need descriptor set binding
518-
Uint32 FilteredCommitMask = CommitSRBMask;
519-
Uint32 ResourceSignaturesCount = m_pPipelineState->GetResourceSignatureCount();
520-
for (Uint32 sign = 0; sign < ResourceSignaturesCount; ++sign)
521-
{
522-
if ((CommitSRBMask & (1u << sign)) != 0)
523-
{
524-
const ShaderResourceCacheVk* pResourceCache = BindInfo.ResourceCaches[sign];
525-
if (pResourceCache != nullptr && pResourceCache->GetNumDescriptorSets() == 0)
526-
{
527-
// This SRB only has push constants, no descriptor sets to commit
528-
FilteredCommitMask &= ~(1u << sign);
529-
}
530-
}
531-
}
532-
533-
// If all SRBs were filtered out (only push constants), nothing to commit
534-
if (FilteredCommitMask == 0)
535-
return;
536-
537516
const Uint32 FirstSign = PlatformMisc::GetLSB(CommitSRBMask);
538517
const Uint32 LastSign = PlatformMisc::GetMSB(CommitSRBMask);
539518
VERIFY_EXPR(LastSign < m_pPipelineState->GetResourceSignatureCount());

0 commit comments

Comments
 (0)