Fix VSync off on Windows 11 (close #648)

Author: TheMostDiligent

Graphics/GraphicsEngineD3D11/src/SwapChainD3D11Impl.cpp

@@ -1,5 +1,5 @@
 /*
- *  Copyright 2019-2022 Diligent Graphics LLC
+ *  Copyright 2019-2025 Diligent Graphics LLC
  *  Copyright 2015-2019 Egor Yusov
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
@@ -152,7 +152,7 @@ void SwapChainD3D11Impl::Present(Uint32 SyncInterval)
     // https://docs.microsoft.com/en-us/windows/uwp/gaming/reduce-latency-with-dxgi-1-3-swap-chains#step-4-wait-before-rendering-each-frame
     WaitForFrame();
 
-    m_pSwapChain->Present(SyncInterval, 0);
+    PresentInternal(SyncInterval);
 }
 
 void SwapChainD3D11Impl::UpdateSwapChain(bool CreateNew)

Graphics/GraphicsEngineD3D12/src/SwapChainD3D12Impl.cpp

@@ -1,5 +1,5 @@
 /*
- *  Copyright 2019-2022 Diligent Graphics LLC
+ *  Copyright 2019-2025 Diligent Graphics LLC
  *  Copyright 2015-2019 Egor Yusov
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
@@ -154,7 +154,7 @@ void SwapChainD3D12Impl::Present(Uint32 SyncInterval)
     // https://docs.microsoft.com/en-us/windows/uwp/gaming/reduce-latency-with-dxgi-1-3-swap-chains#step-4-wait-before-rendering-each-frame
     WaitForFrame();
 
-    auto hr = m_pSwapChain->Present(SyncInterval, 0);
+    auto hr = PresentInternal(SyncInterval);
     VERIFY(SUCCEEDED(hr), "Present failed");
 
     if (m_SwapChainDesc.IsPrimary)

Graphics/GraphicsEngineD3DBase/CMakeLists.txt

@@ -32,6 +32,7 @@ set(SOURCE
     src/DXGITypeConversions.cpp
     src/ShaderD3DBase.cpp
     src/ShaderResources.cpp
+    src/SwapChainD3DBase.cpp
 )
 
 add_library(Diligent-GraphicsEngineD3DBase STATIC

Graphics/GraphicsEngineD3DBase/include/SwapChainD3DBase.hpp

@@ -1,5 +1,5 @@
 /*
- *  Copyright 2019-2023 Diligent Graphics LLC
+ *  Copyright 2019-2025 Diligent Graphics LLC
  *  Copyright 2015-2019 Egor Yusov
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
@@ -31,13 +31,16 @@
 #include "SwapChainBase.hpp"
 #include "DXGITypeConversions.hpp"
 #include "GraphicsAccessories.hpp"
+#include "D3DErrors.hpp"
 
 /// \file
 /// Base implementation of a D3D swap chain
 
 namespace Diligent
 {
 
+bool CheckDXGITearingSupport(IDXGIFactory2* pDXGIFactory2);
+
 /// Base implementation of a D3D swap chain
 template <class BaseInterface, typename DXGISwapChainType>
 class SwapChainD3DBase : public SwapChainBase<BaseInterface>
@@ -101,7 +104,7 @@ class SwapChainD3DBase : public SwapChainBase<BaseInterface>
     void CreateDXGISwapChain(IUnknown* pD3D11DeviceOrD3D12CmdQueue)
     {
 #if PLATFORM_WIN32
-        auto hWnd = reinterpret_cast<HWND>(m_Window.hWnd);
+        HWND hWnd = reinterpret_cast<HWND>(m_Window.hWnd);
         if (m_SwapChainDesc.Width == 0 || m_SwapChainDesc.Height == 0)
         {
             RECT rc;
@@ -124,7 +127,7 @@ class SwapChainD3DBase : public SwapChainBase<BaseInterface>
         m_DesiredPreTransform        = SURFACE_TRANSFORM_OPTIMAL;
         m_SwapChainDesc.PreTransform = SURFACE_TRANSFORM_IDENTITY;
 
-        auto DXGIColorBuffFmt = TexFormatToDXGI_Format(m_SwapChainDesc.ColorBufferFormat);
+        DXGI_FORMAT DXGIColorBuffFmt = TexFormatToDXGI_Format(m_SwapChainDesc.ColorBufferFormat);
 
         DXGI_SWAP_CHAIN_DESC1 swapChainDesc = {};
 
@@ -199,18 +202,27 @@ class SwapChainD3DBase : public SwapChainBase<BaseInterface>
         // DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT enables querying a waitable object that can be
         // used to synchronize presentation with CPU timeline.
         // The flag is not supported in D3D11 fullscreen mode.
-        if (!(m_FSDesc.Fullscreen && m_pRenderDevice->GetDeviceInfo().Type == RENDER_DEVICE_TYPE_D3D11))
+        if (!m_FSDesc.Fullscreen)
         {
-            // We do not need pDXGIFactory3 itself, however DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT flag
-            // is only supported starting with Windows 8.1, and so is IDXGIFactory3 interface. We query this
-            // interface to check Windows 8.1.
-            // Note that we can't use IsWindows8Point1OrGreater because unlike IsWindows8OrGreater, it returns
-            // false if an application is not manifested for Windows 8.1 or Windows 10, even if the current
-            // operating system version is Windows 8.1 or Windows 10.
-            CComPtr<IDXGIFactory3> pDXGIFactory3;
-            if (SUCCEEDED(pDXGIFactory.QueryInterface(&pDXGIFactory3)))
+            if (m_pRenderDevice->GetDeviceInfo().Type == RENDER_DEVICE_TYPE_D3D11)
+            {
+                // We do not need pDXGIFactory3 itself, however DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT flag
+                // is only supported starting with Windows 8.1, and so is IDXGIFactory3 interface. We query this
+                // interface to check Windows 8.1.
+                // Note that we can't use IsWindows8Point1OrGreater because unlike IsWindows8OrGreater, it returns
+                // false if an application is not manifested for Windows 8.1 or Windows 10, even if the current
+                // operating system version is Windows 8.1 or Windows 10.
+                CComPtr<IDXGIFactory3> pDXGIFactory3;
+                if (SUCCEEDED(pDXGIFactory.QueryInterface(&pDXGIFactory3)))
+                {
+                    swapChainDesc.Flags |= DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT;
+                }
+            }
+
+            if (CheckDXGITearingSupport(pDXGIFactory))
             {
-                swapChainDesc.Flags |= DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT;
+                m_TearingSupported = true;
+                swapChainDesc.Flags |= DXGI_SWAP_CHAIN_FLAG_ALLOW_TEARING;
             }
         }
 
@@ -284,9 +296,9 @@ class SwapChainD3DBase : public SwapChainBase<BaseInterface>
         // https://docs.microsoft.com/en-us/windows/uwp/gaming/reduce-latency-with-dxgi-1-3-swap-chains#step-4-wait-before-rendering-each-frame
         if (m_FrameLatencyWaitableObject != NULL)
         {
-            auto Res = WaitForSingleObjectEx(m_FrameLatencyWaitableObject,
-                                             500, // 0.5 second timeout (shouldn't ever occur)
-                                             true);
+            DWORD Res = WaitForSingleObjectEx(m_FrameLatencyWaitableObject,
+                                              500, // 0.5 second timeout (shouldn't ever occur)
+                                              true);
             if (Res != WAIT_OBJECT_0)
             {
                 const char* ErrorMsg = Res == WAIT_TIMEOUT ?
@@ -360,8 +372,23 @@ class SwapChainD3DBase : public SwapChainBase<BaseInterface>
         }
     }
 
+protected:
     virtual void SetDXGIDeviceMaximumFrameLatency() {}
 
+    HRESULT PresentInternal(Uint32 SyncInterval)
+    {
+        if (!m_pSwapChain)
+            return E_FAIL;
+
+        UINT Flags = 0;
+        // DXGI_PRESENT_ALLOW_TEARING can only be used with sync interval 0
+        if (SyncInterval == 0 && m_TearingSupported)
+            Flags |= DXGI_PRESENT_ALLOW_TEARING;
+
+        return m_pSwapChain->Present(SyncInterval, Flags);
+    }
+
+protected:
     using TBase::m_pRenderDevice;
     using TBase::m_SwapChainDesc;
     using TBase::m_DesiredPreTransform;
@@ -372,7 +399,8 @@ class SwapChainD3DBase : public SwapChainBase<BaseInterface>
 
     HANDLE m_FrameLatencyWaitableObject = NULL;
 
-    Uint32 m_MaxFrameLatency = 0;
+    Uint32 m_MaxFrameLatency  = 0;
+    bool   m_TearingSupported = false;
 };
 
 } // namespace Diligent

Graphics/GraphicsEngineD3DBase/src/SwapChainD3DBase.cpp

@@ -0,0 +1,50 @@
+/*
+ *  Copyright 2025 Diligent Graphics LLC
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ *
+ *  In no event and under no legal theory, whether in tort (including negligence),
+ *  contract, or otherwise, unless required by applicable law (such as deliberate
+ *  and grossly negligent acts) or agreed to in writing, shall any Contributor be
+ *  liable for any damages, including any direct, indirect, special, incidental,
+ *  or consequential damages of any character arising as a result of this License or
+ *  out of the use or inability to use the software (including but not limited to damages
+ *  for loss of goodwill, work stoppage, computer failure or malfunction, or any and
+ *  all other commercial damages or losses), even if such Contributor has been advised
+ *  of the possibility of such damages.
+ */
+
+#include "WinHPreface.h"
+#include <dxgi1_5.h>
+#include <atlcomcli.h>
+#include "WinHPostface.h"
+
+#include "SwapChainD3DBase.hpp"
+
+namespace Diligent
+{
+
+bool CheckDXGITearingSupport(IDXGIFactory2* pDXGIFactory2)
+{
+    CComPtr<IDXGIFactory5> pDXGIFactory5;
+    if (FAILED(pDXGIFactory2->QueryInterface(__uuidof(pDXGIFactory5), reinterpret_cast<void**>(static_cast<IDXGIFactory5**>(&pDXGIFactory5)))))
+        return false;
+
+    BOOL AllowTearing = FALSE;
+    if (FAILED(pDXGIFactory5->CheckFeatureSupport(DXGI_FEATURE_PRESENT_ALLOW_TEARING, &AllowTearing, sizeof(AllowTearing))))
+        return false;
+
+    return AllowTearing;
+}
+
+} // namespace Diligent