Check for overwriting existing SRB pointer in CreateShaderResourceBinding

Author: TheMostDiligent

Graphics/GraphicsEngine/include/PipelineResourceSignatureBase.hpp

@@ -1,5 +1,5 @@
 /*
- *  Copyright 2019-2022 Diligent Graphics LLC
+ *  Copyright 2019-2024 Diligent Graphics LLC
  *  Copyright 2015-2019 Egor Yusov
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
@@ -524,6 +524,13 @@ class PipelineResourceSignatureBase : public DeviceObjectBase<typename EngineImp
     virtual void DILIGENT_CALL_TYPE CreateShaderResourceBinding(IShaderResourceBinding** ppShaderResourceBinding,
                                                                 bool                     InitStaticResources) override final
     {
+        if (ppShaderResourceBinding == nullptr)
+        {
+            DEV_ERROR("ppShaderResourceBinding must not be null");
+            return;
+        }
+        DEV_CHECK_ERR(*ppShaderResourceBinding == nullptr, "Overwriting existing shader resource binding pointer may cause memory leaks.");
+
         auto* pThisImpl{static_cast<PipelineResourceSignatureImplType*>(this)};
         auto& SRBAllocator{pThisImpl->GetDevice()->GetSRBAllocator()};
         auto* pResBindingImpl{NEW_RC_OBJ(SRBAllocator, "ShaderResourceBinding instance", ShaderResourceBindingImplType)(pThisImpl)};

Graphics/GraphicsEngine/include/PipelineStateBase.hpp

@@ -568,6 +568,13 @@ class PipelineStateBase : public DeviceObjectBase<typename EngineImplTraits::Pip
     virtual void DILIGENT_CALL_TYPE CreateShaderResourceBinding(IShaderResourceBinding** ppShaderResourceBinding,
                                                                 bool                     InitStaticResources) override final
     {
+        if (ppShaderResourceBinding == nullptr)
+        {
+            DEV_ERROR("ppShaderResourceBinding must not be null");
+            return;
+        }
+        DEV_CHECK_ERR(*ppShaderResourceBinding == nullptr, "Overwriting existing shader resource binding pointer may cause a memory leak.");
+
         CheckPipelineReady();
 
         *ppShaderResourceBinding = nullptr;