Skip to content

Commit d82d679

Browse files
HnCamera: removed UsdCamLensUnitScale as it is applied by the scene delegate
1 parent 8f93e77 commit d82d679

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Hydrogent/src/HnCamera.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,13 @@ void HnCamera::Sync(pxr::HdSceneDelegate* SceneDelegate,
7979
// Reading the attribute will return same value:
8080
// float focalLength;
8181
// UsdCamera.GetFocalLengthAttr().Get(&focalLength); // focalLength == 30
82-
// However
82+
//
83+
// Scene delegate, however, applies 0.1 scale when reading the property, so we don't need to
8384
// focalLength = SceneDelegate->GetCameraParamValue(id, HdCameraTokens->focalLength).Get<float>(); // focalLength == 3
84-
constexpr float UsdCamLensUnitScale = 10;
85-
const float HorzApertureUnits = GetHorizontalAperture() * UsdCamLensUnitScale;
86-
const float VertApertureUnits = GetVerticalAperture() * UsdCamLensUnitScale;
87-
const float FocalLengthUnits = GetFocalLength() * UsdCamLensUnitScale;
88-
const pxr::GfRange1f ClippingRangeUnits = GetClippingRange();
85+
const float HorzApertureUnits = GetHorizontalAperture();
86+
const float VertApertureUnits = GetVerticalAperture();
87+
const float FocalLengthUnits = GetFocalLength();
88+
const pxr::GfRange1f ClippingRangeUnits = GetClippingRange();
8989

9090
// Diligent expects camera attributes in world units
9191
const float HorzApertureMeters = HorzApertureUnits * MetersPerUnit;

0 commit comments

Comments
 (0)