CODE RUB: Implement TryCatch

Author: DilmurodDeveloper

LibraryManagement.Api/Services/Foundations/Books/BookService.Exceptions.cs

@@ -7,6 +7,7 @@
 using LibraryManagement.Api.Models.Foundations.Books;
 using LibraryManagement.Api.Models.Foundations.Books.Exceptions;
 using Microsoft.Data.SqlClient;
+using Microsoft.EntityFrameworkCore;
 using Xeptions;
 
 namespace LibraryManagement.Api.Services.Foundations.Books
@@ -34,6 +35,20 @@ private async ValueTask<Book> TryCatch(ReturningBookFunction returningBookFuncti
             {
                 throw CreateAndLogValidationException(notFoundBookException);
             }
+            catch (DbUpdateConcurrencyException dbUpdateConcurrencyException)
+            {
+                var lockedBookException =
+                    new LockedBookException(dbUpdateConcurrencyException);
+
+                throw CreateAndLogDependencyValidationException(lockedBookException);
+            }
+            catch (DbUpdateException dbUpdateException)
+            {
+                var failedBookStorageException =
+                    new FailedBookStorageException(dbUpdateException);
+
+                throw CreateAndLogDependencyException(failedBookStorageException);
+            }
             catch (SqlException sqlException)
             {
                 var failedBookStorageException =
@@ -118,5 +133,15 @@ private BookServiceException CreateAndLogServiceException(Xeption exception)
 
             return bookServiceException;
         }
+
+        private BookDependencyException CreateAndLogDependencyException(Xeption exception)
+        {
+            var bookDependencyException =
+                new BookDependencyException(exception);
+
+            this.loggingBroker.LogError(bookDependencyException);
+
+            return bookDependencyException;
+        }
     }
 }

LibraryManagement.Api/Services/Foundations/Books/BookService.cs

@@ -6,9 +6,6 @@
 using LibraryManagement.Api.Brokers.Loggings;
 using LibraryManagement.Api.Brokers.Storages;
 using LibraryManagement.Api.Models.Foundations.Books;
-using LibraryManagement.Api.Models.Foundations.Books.Exceptions;
-using Microsoft.Data.SqlClient;
-using Microsoft.EntityFrameworkCore;
 
 namespace LibraryManagement.Api.Services.Foundations.Books
 {
@@ -49,94 +46,17 @@ public ValueTask<Book> RetrieveBookByIdAsync(Guid bookId) =>
             return maybeBook;
         });
 
-        public async ValueTask<Book> ModifyBookAsync(Book book)
+        public ValueTask<Book> ModifyBookAsync(Book book) =>
+        TryCatch(async () =>
         {
-            try
-            {
-                ValidateBookOnModify(book);
-
-                Book maybeBook =
-                    await this.storageBroker.SelectBookByIdAsync(book.BookId);
-
-                ValidateAgainstStorageBookOnModify(book, maybeBook);
-
-                return await this.storageBroker.UpdateBookAsync(book);
-            }
-            catch (NullBookException nullBookException)
-            {
-                var bookValidationException =
-                    new BookValidationException(nullBookException);
-
-                this.loggingBroker.LogError(bookValidationException);
-
-                throw bookValidationException;
-            }
-            catch (InvalidBookException invalidBookException)
-            {
-                var bookValidationException =
-                    new BookValidationException(invalidBookException);
-
-                this.loggingBroker.LogError(bookValidationException);
-
-                throw bookValidationException;
-            }
-            catch (NotFoundBookException notFoundBookException)
-            {
-                var bookValidationException =
-                    new BookValidationException(notFoundBookException);
-
-                this.loggingBroker.LogError(bookValidationException);
-
-                throw bookValidationException;
-            }
-            catch (SqlException sqlException)
-            {
-                var failedBookStorageException =
-                    new FailedBookStorageException(sqlException);
-
-                var bookDependencyException =
-                    new BookDependencyException(failedBookStorageException);
+            ValidateBookOnModify(book);
 
-                this.loggingBroker.LogCritical(bookDependencyException);
-
-                throw bookDependencyException;
-            }
-            catch (DbUpdateConcurrencyException dbUpdateConcurrencyException)
-            {
-                var lockedBookException =
-                    new LockedBookException(dbUpdateConcurrencyException);
-
-                var bookDependencyValidationException =
-                    new BookDependencyValidationException(lockedBookException);
-
-                this.loggingBroker.LogError(bookDependencyValidationException);
-
-                throw bookDependencyValidationException;
-            }
-            catch (DbUpdateException dbUpdateException)
-            {
-                var failedBookStorageException =
-                    new FailedBookStorageException(dbUpdateException);
-
-                var bookDependencyException =
-                    new BookDependencyException(failedBookStorageException);
-
-                this.loggingBroker.LogError(bookDependencyException);
-
-                throw bookDependencyException;
-            }
-            catch (Exception exception)
-            {
-                var failedBookServiceException =
-                    new FailedBookServiceException(exception);
-
-                var bookServiceException =
-                    new BookServiceException(failedBookServiceException);
+            Book maybeBook =
+                await this.storageBroker.SelectBookByIdAsync(book.BookId);
 
-                this.loggingBroker.LogError(bookServiceException);
+            ValidateAgainstStorageBookOnModify(book, maybeBook);
 
-                throw bookServiceException;
-            }
-        }
+            return await this.storageBroker.UpdateBookAsync(book);
+        });
     }
 }