CODE RUB: Implement TryCatch

Author: DilmurodDeveloper

LibraryManagement.Api/Services/Foundations/Readers/ReaderService.Exceptions.cs

@@ -7,6 +7,7 @@
 using LibraryManagement.Api.Models.Foundations.Readers;
 using LibraryManagement.Api.Models.Foundations.Readers.Exceptions;
 using Microsoft.Data.SqlClient;
+using Microsoft.EntityFrameworkCore;
 using Xeptions;
 
 namespace LibraryManagement.Api.Services.Foundations.Readers
@@ -34,6 +35,20 @@ private async ValueTask<Reader> TryCatch(ReturningReaderFunction returningReader
             {
                 throw CreateAndLogValidationException(notFoundReaderException);
             }
+            catch (DbUpdateConcurrencyException dbUpdateConcurrencyException)
+            {
+                var lockedReaderException =
+                    new LockedReaderException(dbUpdateConcurrencyException);
+
+                throw CreateAndLogDependencyValidationException(lockedReaderException);
+            }
+            catch (DbUpdateException dbUpdateException)
+            {
+                var failedReaderStorageException =
+                    new FailedReaderStorageException(dbUpdateException);
+
+                throw CreateAndLogDependencyException(failedReaderStorageException);
+            }
             catch (SqlException sqlException)
             {
                 var failedReaderStorageException =
@@ -115,5 +130,13 @@ private ReaderServiceException CreateAndLogServiceException(Xeption exception)
 
             return readerServiceException;
         }
+
+        private ReaderDependencyException CreateAndLogDependencyException(Xeption exception)
+        {
+            var readerDependencyException = new ReaderDependencyException(exception);
+            this.loggingBroker.LogError(readerDependencyException);
+
+            return readerDependencyException;
+        }
     }
 }

LibraryManagement.Api/Services/Foundations/Readers/ReaderService.cs

@@ -6,9 +6,6 @@
 using LibraryManagement.Api.Brokers.Loggings;
 using LibraryManagement.Api.Brokers.Storages;
 using LibraryManagement.Api.Models.Foundations.Readers;
-using LibraryManagement.Api.Models.Foundations.Readers.Exceptions;
-using Microsoft.Data.SqlClient;
-using Microsoft.EntityFrameworkCore;
 
 namespace LibraryManagement.Api.Services.Foundations.Readers
 {
@@ -49,94 +46,17 @@ public ValueTask<Reader> RetrieveReaderByIdAsync(Guid readerId) =>
             return maybeReader;
         });
 
-        public async ValueTask<Reader> ModifyReaderAsync(Reader reader)
+        public ValueTask<Reader> ModifyReaderAsync(Reader reader) =>
+        TryCatch(async () =>
         {
-            try
-            {
-                ValidateReaderOnModify(reader);
-
-                Reader maybeReader =
-                    await this.storageBroker.SelectReaderByIdAsync(reader.ReaderId);
-
-                ValidateAgainstStorageReaderOnModify(reader, maybeReader);
-
-                return await this.storageBroker.UpdateReaderAsync(reader);
-            }
-            catch (NullReaderException nullReaderException)
-            {
-                var readerValidationException =
-                    new ReaderValidationException(nullReaderException);
-
-                this.loggingBroker.LogError(readerValidationException);
-
-                throw readerValidationException;
-            }
-            catch (InvalidReaderException invalidReaderException)
-            {
-                var readerValidationException =
-                    new ReaderValidationException(invalidReaderException);
-
-                this.loggingBroker.LogError(readerValidationException);
-
-                throw readerValidationException;
-            }
-            catch (NotFoundReaderException notFoundReaderException)
-            {
-                var readerValidationException =
-                    new ReaderValidationException(notFoundReaderException);
-
-                this.loggingBroker.LogError(readerValidationException);
-
-                throw readerValidationException;
-            }
-            catch (SqlException sqlException)
-            {
-                var failedReaderStorageException =
-                    new FailedReaderStorageException(sqlException);
-
-                var readerDependencyException =
-                    new ReaderDependencyException(failedReaderStorageException);
+            ValidateReaderOnModify(reader);
 
-                this.loggingBroker.LogCritical(readerDependencyException);
-
-                throw readerDependencyException;
-            }
-            catch (DbUpdateConcurrencyException dbUpdateConcurrencyException)
-            {
-                var lockedReaderException =
-                    new LockedReaderException(dbUpdateConcurrencyException);
-
-                var readerDependencyValidationException =
-                    new ReaderDependencyValidationException(lockedReaderException);
-
-                this.loggingBroker.LogError(readerDependencyValidationException);
-
-                throw readerDependencyValidationException;
-            }
-            catch (DbUpdateException dbUpdateException)
-            {
-                var failedReaderStorageException =
-                    new FailedReaderStorageException(dbUpdateException);
-
-                var readerDependencyException =
-                    new ReaderDependencyException(failedReaderStorageException);
-
-                this.loggingBroker.LogError(readerDependencyException);
-
-                throw readerDependencyException;
-            }
-            catch (Exception exception)
-            {
-                var failedReaderServiceException =
-                    new FailedReaderServiceException(exception);
-
-                var readerServiceException =
-                    new ReaderServiceException(failedReaderServiceException);
+            Reader maybeReader =
+                await this.storageBroker.SelectReaderByIdAsync(reader.ReaderId);
 
-                this.loggingBroker.LogError(readerServiceException);
+            ValidateAgainstStorageReaderOnModify(reader, maybeReader);
 
-                throw readerServiceException;
-            }
-        }
+            return await this.storageBroker.UpdateReaderAsync(reader);
+        });
     }
 }