Merge pull request #1638 from DimensionDev/bugfix/deeplink_query

ignore deeplink query

Author: Tlaster

shared/src/commonMain/kotlin/dev/dimension/flare/common/deeplink/DeepLinkMatcher.kt

@@ -62,10 +62,11 @@ internal class DeepLinkMatcher<T>(
         // match queries (if any)
         request.queries.forEach { query ->
             val name = query.key
-            val queryStringParser = deepLinkPattern.queryValueParsers[name]
+            // if the query param is not part of the pattern, we just ignore it
+            val queryStringParser = deepLinkPattern.queryValueParsers[name] ?: return@forEach
             val queryParsedValue =
                 try {
-                    queryStringParser!!.invoke(query.value.first())
+                    queryStringParser.invoke(query.value.first())
                 } catch (e: IllegalArgumentException) {
                     DebugRepository.log(
                         "${TAG_LOG_ERROR}: Failed to parse query name:[$name] value:[${query.value}]." +

shared/src/commonTest/kotlin/dev/dimension/flare/common/deeplink/DeepLinkMatcherTest.kt

@@ -109,6 +109,28 @@ class DeepLinkMatcherTest {
         assertNull(match)
     }
 
+    @Test
+    fun ignoresUnknownQueryParameters() {
+        val patternUrl =
+            URLBuilder("https://example.com")
+                .apply { path("test", "{param}") }
+                .build()
+        val requestUrl =
+            URLBuilder("https://example.com")
+                .apply {
+                    path("test", "param_value")
+                    parameters.append("q", "test")
+                }.build()
+        val pattern = DeepLinkPattern(TestParamKey.serializer(), patternUrl)
+        val request = DeepLinkRequest(requestUrl)
+
+        val match = DeepLinkMatcher(request, pattern).match()
+
+        assertNotNull(match)
+        assertEquals(TestParamKey.serializer(), match.serializer)
+        assertEquals(mapOf("param" to "param_value"), match.args)
+    }
+
     @Serializable
     private data class HomeKey(
         val value: String = "",
@@ -120,4 +142,9 @@ class DeepLinkMatcherTest {
         val includeHistory: Boolean = false,
         val page: Long = 0,
     )
+
+    @Serializable
+    private data class TestParamKey(
+        val param: String,
+    )
 }