Skip to content

Commit 6a3c6c3

Browse files
authored
Merge pull request #1659 from DimensionDev/bugfix/video_player_memory_leak
fix memory leak for video player
2 parents 4603624 + 5539638 commit 6a3c6c3

File tree

1 file changed

+6
-1
lines changed
  • compose-ui/src/androidMain/kotlin/dev/dimension/flare/ui/component

1 file changed

+6
-1
lines changed

compose-ui/src/androidMain/kotlin/dev/dimension/flare/ui/component/VideoPlayer.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,11 @@ public fun VideoPlayer(
259259
it
260260
}
261261
}
262+
DisposableEffect(Unit) {
263+
onDispose {
264+
player.clearVideoSurface()
265+
}
266+
}
262267
Box {
263268
PlayerSurface(
264269
player = player,
@@ -303,7 +308,7 @@ public class SurfaceBindingManager(
303308
) {
304309
public val player: ExoPlayer by lazy {
305310
ExoPlayer
306-
.Builder(context)
311+
.Builder(context.applicationContext)
307312
.build()
308313
.apply {
309314
playWhenReady = true

0 commit comments

Comments
 (0)